Powershell ForEach loop, to send a file to multiple locations, not working

Question

I am attempting to send one file to multiple locations using a ForEach loop.

It gets sent to one location, but not the second. I have noticed that the second location gets output to the host, though, which is a bit strange to me.

Code:

$filename = "test.txt"
$Fullpath = "C:\Path\To\Folder\"+$filename
$Testpath1 = "C:\Path\To\Folder\TestCopyTo\"
$Testpath2 = "C:\Path\To\Folder\TestCopyTo_SecondPath\"
$TESTFilepaths = $Testpath1;$Testpath2
$FilePathList = $TESTFilepaths.split(';')
    
foreach($Path in $FilePathList){
                        
    Write-Host "Copying $Filename to $Path"

    Copy-Item $Fullpath -destination $Path 
    
}

Output:

As per above, it makes it to TestCopyTo, but not TestCopyTo_SecondPath

I have been wracking my brain for half a day over this, and I am sure it is something simple!

Thanks

========== EDIT EDIT =============

I FIGURED IT OOOOUUUTT! Almost a whole workday because of these stupid little things: +';'+

It's always something small. I know you all feel me right now.

Fixed code:

$filename = "test.txt"
$Fullpath = "C:\FIS\Site\Quantum Reporting\Output\"+$filename
$Testpath1 = "C:\FIS\Site\Quantum Reporting\Output\TestCopyTo"
$Testpath2 = "C:\FIS\Site\Quantum Reporting\Output\TestCopyTo_SecondPath"
$TESTFilepaths = $Testpath1+';'+$Testpath2
$FilePathList = $TESTFilepaths.split(';')

foreach($Path in $FilePathList){
                        
    Write-Host "Copying $Filename to $Path"

    Copy-Item $Fullpath -destination $Path 
    
}

The reason for the complications, as mentioned by the commenter, is due to the real world code being complicated. Data is extracted with a semi colon and that worked fine in 'Production', but issues arose when I added a test section to the script. I wrote it to tell the difference between production and test, to automate testing as much as I could.

In the real world, the semi colon is a part of the string already. In the Test section of the code I had to make it a part of the string using the quotes.

~picard_facepalm.gif~

Avshalom · Accepted Answer · 2022-12-20 06:51:16Z

1

Your code is a little bit complex. you just need to create an array with the paths and iterate it, like this:

$filename = "test.txt"
$FilePathList = @("C:\Path\To\Folder","C:\Path\To\Folder\TestCopyTo",
"C:\Path\To\Folder\TestCopyTo_SecondPath")
    
foreach($Path in $FilePathList){
    Write-Host "Copying $Filename to $Path"
    $Fullpath = Join-Path $Path $filename
    Copy-Item $Fullpath -Destination $Path
}

answered Dec 20, 2022 at 6:51

Avshalom

8,9471 gold badge29 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Chris Over a year ago

Thanks, but your example now has no source path. Or it's copying from itself to itself.

Chris Over a year ago

Also, just as an aside, the semi colon it what appears in a real world scenario, which is why I have it like that

Collectives™ on Stack Overflow

Powershell ForEach loop, to send a file to multiple locations, not working

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related