Node.js async await won't work with db query

Question

app.get('/someApi', async (req, res) => {
    var a = await SomeMethod();
})

function SomeMethod() 
{
 let sql = 'SELECT * FROM someTable'
    var query = db.query(sql, (err, results) =>{
        if(err)
        {
            throw err
        }
       if(results ... some logic)
        {
          return true;
        }
       else{
          return false;
       }
    })
}

If i call SomeMethod from someApi it will pass the line and say that var a = undefined instead of true or false. I need to get a response, true/false before going to next line after var a in someApi.

Also if i return true/false outside of db.query it will work fine. Is a problem in that db.query. Also if i return true/false without results ... some logic it will behave the same, skip lane and says var a = undefined. — Seb
– Seb, Commented Jan 16, 2023 at 13:20

0xdw · Accepted Answer · 2023-01-16 13:21:06Z

1

Convert the callback function to a promise and then use await on it.

function SomeMethod() {
    return new Promise((resolve, reject) => {
        let sql = 'SELECT * FROM someTable'
        db.query(sql, (err, results) => {
            if (err) {
                reject(err);
            }
            if (results) {
                resolve(true);
            }
            else {
                resolve(false);
            }
        });
    });
}

app.get('/someApi', async (req, res) => {
    var a = await SomeMethod();
});

answered Jan 16, 2023 at 13:21

0xdw

3,8522 gold badges29 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Seb Over a year ago

Works fine with Promise, thanks!!

0xdw Over a year ago

@Seb. Glad it hepped. You can accept the answer if it works.

Seb Over a year ago

u answered so fast that i couldnt accept the answer in less than 10mins as the stackoverflow rulles says

0xdw Over a year ago

@Seb Oh, that is something I never heard about :\

Collectives™ on Stack Overflow

Node.js async await won't work with db query

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related