NestJS not handling error from thrown from service in controller

Question

I have a simple setup where I'm calling a service method from the controller like so:

// companies.controller.ts

@Controller("company")
export class CompaniesController {
  constructor(private companiesService: CompaniesService) {}

  @Post("/:id/upload")
  @UseInterceptors(FilesInterceptor("file"))
  uploadFiles(
    @Param("id") id: string,
    @UploadedFiles() files: Array<Express.Multer.File>,
  ) {
    // throw new HttpException("Company not found", HttpStatus.NOT_ACCEPTABLE);
    // console.log(files);
    try {
      this.companiesService.uploadFiles(id, files);
      console.log("didn't get error");
    } catch (error) {
      console.log("got error");
      throw new HttpException("forbidden", HttpStatus.FORBIDDEN);
    }
  }
}

// companies.service.ts

@Injectable()
export class CompaniesService {
  constructor(
    private prisma: PrismaService,
    private s3Service: S3Service,
    private filesService: FilesService,
  ) {}

  async uploadFiles(id: Company["id"], files: Array<Express.Multer.File>) {
    const company = false // for testing

    if (!company) {
      console.log("Company not found");
      throw new Error();
    }
}

I'm running this by using nest start --watch.

When I call this endpoint, My app quits and I get the following logged to my console:

didn't get error
Company not found

/src/companies/companies.service.ts:54
      throw new Error();
            ^
Error: 
    at CompaniesService.uploadFiles (/src/companies/companies.service.ts:54:13)

How come I can't catch the error I'm throwing in my controller? It's clearly not catching because it's logging company not found. Exception Filtering is supposed to be built in by default so I'm not sure why this isn't producing a 500?

Jackie McDoniel · Accepted Answer · 2023-01-19 20:14:02Z

8

You aren't awaiting the this.companiesService.uploadFiles(id, files); call, which means that it is an unhandled promise. If anything errors from it, it's an unhandled rejection. Just add async to the uploadFiles in the controller and await to thethis.companiesService.uploadFiles call and you should be good to go

answered Jan 19, 2023 at 20:14

Jackie McDoniel

71.7k9 gold badges191 silver badges196 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Alex McLean Over a year ago

Yes, that was it! I knew it had to be something silly I was missing. Thank you!

Collectives™ on Stack Overflow

NestJS not handling error from thrown from service in controller

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related