Why doesn't return getter like in Java (C#)

Question

I want to move from Java to C# and I want to try getter and setter like in Java

internal class Person
    {
 
        internal string name;
        

        internal void setName (string name)
        {
            this.name = name;   
        }

        internal string getName ()
        {
            return this.name;
        }

    }

in main:

Person alex = new Person();
alex.setName("alex");
Console.WriteLine(alex.getName);

and the output is:

System.Func`1[System.String]

Why doesn't display the expected "alex" ?

You're missing the paranethesis "()". Console.WriteLine(alex.getName()) — t.haeusler
– t.haeusler, Commented Mar 14, 2023 at 10:39
Apart from the console issue, use C# properties instead. A Person has a Name and not a SetName/GetName. — Tim Schmelter
– Tim Schmelter, Commented Mar 14, 2023 at 10:40
Marking everything internal is probably also not what you want -- if the field has the same accessibility as its getter/setter, nothing prevents clients from manipulating it directly. In C# code you'd expect public string Name { get; set; }. — Jeroen Mostert
– Jeroen Mostert, Commented Mar 14, 2023 at 10:41
Use properties. C# isn't Java and properties are actual concepts, parts of an object's API. They aren't just getter and setter methods. Serializers and ORMs will serialize and map properties, not fields. No library will use methods that just have the get and set prefix — Panagiotis Kanavos
– Panagiotis Kanavos, Commented Mar 14, 2023 at 10:42
This is actually a frequent mistake people make in moving between languages - they assume the idioms and patterns they've picked up in a previous language are universally applicable and then try to use those in the new language. It doesn't help you learn the language if you're writing unidiomatic code that no "native" author of the new language would use. — Damien_The_Unbeliever
– Damien_The_Unbeliever, Commented Mar 14, 2023 at 10:48

Bruno Canettieri · Accepted Answer · 2023-03-14 10:42:00Z

3

Because getName is a function, and not a getter. So your code should be

Console.WriteLine(alex.getName());

If you want to use setter and getters, the syntax is

internal class Person
{
  internal string name;
  internal string Name 
  {
    set { this.name = value; }
    get { return this.name; }
  }
}

Or more compact

internal class Person
{
  internal string Name { get; set; }
}

answered Mar 14, 2023 at 10:42

Bruno Canettieri

5012 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Panagiotis Kanavos Over a year ago

The name field shouldn't be internal. Fields are just implementation details. Only properties are part of a class's programming surface

Bruno Canettieri Over a year ago

I can see cases, not really recommended, when you want to set the field directly without passing through the setter. That's why I maintained the original Access modifiers from the question. But it is a valid note.

PMF · Accepted Answer · 2023-03-14 10:43:17Z

1

In C#, properties are used instead of explicit setters/getters. So the above is better written as

internal string Name
{
    get => this.name
    set => this.name = value;
}

or even shorter, with automatic properties:

internal string Name
{
    get;
    set;
}

Additionally, in your statement Console.WriteLine(alex.getName); getName is the method, not it's result, therefore it prints the type of the method. To fix that, change it to Console.WriteLine(alex.getName()); or, with the above property, it will be Console.WriteLine(alex.Name));

answered Mar 14, 2023 at 10:43

PMF

17.6k4 gold badges32 silver badges58 bronze badges

6 Comments

Panagiotis Kanavos Over a year ago

It's not just better, properties are part of an object's API. Fields and get-prefixed methods aren't. Serializers, ORMs, Web frameworks etc all work on properties, none on fields or methods unless explicitly configured

PMF Over a year ago

@PanagiotisKanavos Sure, but nevertheless (if you don't need any of that), it's just syntax. It doesn't really change the behavior when looking at the class alone.

Panagiotis Kanavos Over a year ago

It's not just syntax, yes, it changes behavior. Properties are specified in an assembly's metadata. You can use Type.GetProperty to get a property by name. You can specify properties in interfaces, but not fields. If you use any king of configuration or settings infrastructure, properties are used. You'd have to strip quite a lot of basic functionality to say it's just syntax.

PMF Over a year ago

I see it the other way round: Because we have properties, they're used in many places where it's convenient, like Serializers. But there's nothing that would prevent a library to use Type.GetField instead of Type.GetProperty. And (as in the example above), setXYZ and getXYZ methods can be part of an interface.

Panagiotis Kanavos Over a year ago

That's an opinion that contradicts the language design (actually, the runtime design) itself

|

Collectives™ on Stack Overflow

Why doesn't return getter like in Java (C#)

2 Answers 2

2 Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related