jQuery if multiple objects equal same value

Question

I have multple objects. Before submitting a form, I want to check to be sure all of the object values are "ok".

$("#sub_button").click(function() {
    if (myObj.login_id && myObj.email == "ok")  {
        alert("This would submit the form. login ID obj is: "+myObj.login_id+" and email email obj is: "+myObj.email);
    } else {
        alert("the form is bad!");
    }
});

I've tried it with two == and three ===, it still isn't working. The myObj.login_id or myObj.email could equal ANYTHING and it still pops up the "This would submit the form" alert, and shows in the alert box that the value(s) is NOT "ok".

What am I doing wrong?

Ben Zotto · Accepted Answer · 2011-10-03 16:08:00Z

4

This isn't comparing what you think it's comparing. When you read this aloud, it sounds right: "if login ID and email are equal to OK", but that's not how the && works. You want:

if (myObj.login_id == "ok" && myObj.email == "ok") {
   ....
}

The code you did write actually says "if login ID is anything at all, and if email is "ok" ".

answered Oct 3, 2011 at 16:08

Ben Zotto

71.2k23 gold badges145 silver badges207 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

John Keyes · Accepted Answer · 2011-10-03 16:47:54Z

2

$("#sub_button").click(function() {
    if (myObj.login_id == "ok" && myObj.email == "ok")  {
        alert("This would submit the form. login ID obj is: "+myObj.login_id+" and email email obj is: "+myObj.email);
    } else {
        alert("the form is bad!");
    }
});

edited Oct 3, 2011 at 16:47

John Keyes

5,6142 gold badges33 silver badges51 bronze badges

answered Oct 3, 2011 at 16:07

ryudice

37.6k33 gold badges122 silver badges164 bronze badges

Comments

Nicola Peluchetti · Accepted Answer · 2011-10-03 16:06:59Z

1

You should do:

("#sub_button").click(function() {

    if (myObj.login_id === "ok" && myObj.email === "ok")  {

        alert("This would submit the form. login ID obj is: "+myObj.login_id+" and email email obj is: "+myObj.email);
else {

        alert("the form is bad!");

In your code you just check that myObj.login_id resolves to true (which happens everytime myObj.login_id value is not in this list)

false
null
undefined
The empty string ''
The number 0
The number NaN (yep, 'Not a Number' is a number, it is a special number)

answered Oct 3, 2011 at 16:06

Nicola Peluchetti

77k32 gold badges151 silver badges197 bronze badges

1 Comment

Oseer Over a year ago

I can't believe I didnt catch that. Thank you!

enloz · Accepted Answer · 2011-10-03 16:08:26Z

0

Try this

$("#sub_button").click(function() {

    if (myObj.login_id == "ok" && myObj.email == "ok")  {

        alert("This would submit the form. login ID obj is: "+myObj.login_id+" and email email obj is: "+myObj.email);

    } else {

        alert("the form is bad!");

answered Oct 3, 2011 at 16:08

enloz

5,9049 gold badges39 silver badges57 bronze badges

Comments

CodeCaster · Accepted Answer · 2011-10-03 18:08:14Z

0

(myObj.login_id && myObj.email == "ok") will evaluate to true if myObj.email == "ok" and myObj.login_id has a non-zero value. You're not evaluating the contents of login_id to anything, so it'll be handled as a boolean and converted to such according to the contents.

You should change it to (myObj.login_id == "ok" && myObj.email == "ok").

edited Oct 3, 2011 at 18:08

answered Oct 3, 2011 at 16:07

CodeCaster

153k24 gold badges237 silver badges287 bronze badges

Collectives™ on Stack Overflow

jQuery if multiple objects equal same value

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related