dataframe is not updated while using loc function

Question

Here below a dataframe.

df_strat = pd.DataFrame({'in_pos': [0, 0, 0, 1, 0, 0, -1, 0, 0, 0], 
                    'in': [0, 0, 0, 1, 0, 0, -1, 0, 0, 0]})

I need to update the 'in' column value, either when there is a '1' in the column 'in_pos' or when there is a '1' in the previous row of the 'in' column. Same when values are -1 and -1. And I would extend to any set of value.

So I used the following code only to test '1' values:

df_strat.loc[(df_strat['in_pos'].shift(1) == 1) | (df_strat['in'].shift(1) == 1), 'in'] = 1

I expect a recursive update using the loc method.

But instead, I get only a single row update as below.

I tried the following too :

conditions = [
(df_strat['in_pos'] == 1) | (df_strat['in'].shift(1).fillna(0) == 1),
(df_strat['in_pos'] == -1) | (df_strat['in'].shift(1).fillna(0) == -1),
(df_strat['in_pos'] == 0) | (df_strat['in'].shift(1).fillna(0) == 0)]

df_strat['in'] = np.select(conditions, [1, -1, 0], default=df_strat['in'])

but result is a below

Expected result is

df_expected = pd.DataFrame({'in_pos': [0, 0, 0, 1, 0, 0, -1,0,0,0], 
                    'in': [0, 0, 0, 1, 1, 1, -1, -1, -1,-1]})

Can anyone help ? thks.

Please provide a minimal reproducible example images are not reproducible — mozway
– mozway, Commented Jan 26, 2024 at 16:40
Ditto @mozway, and please provide what your expected output should look like formatted as a code block. — Ian Thompson
– Ian Thompson, Commented Jan 26, 2024 at 16:46
That said, given your example, it makes sense that only 1 value is updated. — mozway
– mozway, Commented Jan 26, 2024 at 16:54
@gfxProg sorry? Have you tested the solution below? Did it work? — mozway
– mozway, Commented Jan 29, 2024 at 12:37

mozway · Accepted Answer · 2024-01-26 17:12:45Z

1

loc doesn't work "recursively". Given your code, it's expected that only one value is changed.

If you want to recursively select the column after a 1, this means that you want to select all columns after your condition is met once.

You can thus use a cummax on your boolean series:

cond = (df_strat['in_pos'].shift(1) == 1) | (df_strat['in'].shift(1) == 1)

# or
# cond = df_strat[['in', 'in_pos']].shift(1).eq(1).any(axis=1)

df.loc[cond.cummax(), 'in'] = 1

Example:

# input
df_strat = pd.DataFrame({'in': [0, 0, 0, 1, 0, 0, 0],
                         'in_pos': [0, 0, 0, 1, 0, 0, 0]})

# output
   in  in_pos
0   0       0
1   0       0
2   0       0
3   1       1
4   1       0
5   1       0
6   1       0

answered Jan 26, 2024 at 17:12

mozway

267k13 gold badges56 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

gfx Prog Over a year ago

thks. looks good but I get stuck when in_pos change value. Let me edit the question part.

mozway Over a year ago

@gfxProg don't forget to provide the matching expected output for your updated input

Collectives™ on Stack Overflow

dataframe is not updated while using loc function

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related