Java converting a cell to string

Question

I have the following Java code: (the parameters are the login data aswell as the query for the database)

public static String connectDB(String configFile, String query) throws FileNotFoundException, IOException, SQLException, ClassNotFoundException {
    Properties p = new Properties();
    p.load(new FileInputStream(configFile));

    String serverName = (p.getProperty("RMS_DBServerName"));
    String portNumber = (p.getProperty("DB_PortNumber"));
    String sid = (p.getProperty("RMS_SID"));
    String url = "jdbc:oracle:thin:@//" + serverName + ":" + portNumber + "/" + sid;
    String username = (p.getProperty("RMS_Username"));
    String password = (p.getProperty("RMS_Password"));

    Class.forName("oracle.jdbc.driver.OracleDriver");
    Connection connection = DriverManager.getConnection(url, username, password);

    try {
        Statement stmt = connection.createStatement();

        try {
            ResultSet rset = stmt.executeQuery(query);
            try {
                while (rset.next()) {
                    System.out.println(rset.getString(1));
                }
            } finally {
                try {
                    rset.close();
                } catch (Exception ignore) {
                }
            }
            return rset;
        } finally {
            try {
                stmt.close();
            } catch (Exception ignore) {
            }
        }
    } finally {
        try {
            connection.close();
        } catch (Exception ignore) {
        }
    }
}

The code is supposed to get the one cell from the database. The query works when the result is given to the console. But I want to return the cell from the method to another method in order to automate the process. But the return is returning code like this: jdbc:oracle:OracleDriver#........ . So can anyone help to fix this, I just want to return one cell that contains a number.

That's a mess to read, by the way--I'd consider wrapping some of that up in utility functions/etc. As it stands, its purpose is buried and difficult to discern. — Dave Newton
– Dave Newton, Commented Oct 21, 2011 at 16:27
Your method is defined to return a String, but yet you are returning a (closed!) ResultSet. Does not make any sense to me. — user330315
– user330315, Commented Oct 21, 2011 at 16:43

Dave Newton · Accepted Answer · 2011-10-21 14:30:48Z

2

Instead of printing the string, return it. Right now you're returning the string representation of the result set.

answered Oct 21, 2011 at 14:30

Dave Newton

161k27 gold badges263 silver badges311 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Andrew Lazarus Over a year ago

that is: return rset.getString(1) in lieu of return rset

hkn · Accepted Answer · 2011-10-21 14:30:49Z

1

Change

while (rset.next())
         System.out.println(rset.getString(1));
}

to

if(rset.next()) {
     return rset.getString(1);
}

and remove

return rset;

answered Oct 21, 2011 at 14:30

hkn

1,44620 silver badges22 bronze badges

4 Comments

Eve Over a year ago

I changed the statement but now it's telling me to add a return when it's clearly now in the code or to change to void but then i have to remove the return

hkn Over a year ago

add return null; to the end of the method

MatBailie Over a year ago

You need a return in every execution path. So return null or an empty string in an else block.

Eve Over a year ago

I added the return null and now it returns NULL so I don't get any data back anymore

Eve · Accepted Answer · 2011-10-25 08:50:37Z

I solved the problem this the code I got

public static String connectDB(String configFile, String query) throws FileNotFoundException, IOException, SQLException, ClassNotFoundException{
    Properties p = new Properties();
    p.load(new FileInputStream(configFile));

    String serverName = (p.getProperty("RMS_DBServerName"));
    String portNumber = (p.getProperty("DB_PortNumber"));
    String sid = (p.getProperty("RMS_SID"));
    String url = "jdbc:oracle:thin:@//" + serverName + ":" + portNumber + "/" + sid;
    String username = (p.getProperty("RMS_Username"));
    String password = (p.getProperty("RMS_Password"));

    Class.forName("oracle.jdbc.driver.OracleDriver");
    Connection connection = DriverManager.getConnection(url,username,password);
    String setr = null;
    try {      
        Statement stmt = connection.createStatement();

        try {ResultSet rset = stmt.executeQuery(query);
            try {
                while(rset.next())   
                    setr = rset.getString(1);
                    return setr;  
            }        
            finally {
                try { rset.close(); 
                } 
                catch (Exception ignore) {}

            }
        } 
        finally {
            try { stmt.close(); 
            } 
            catch (Exception ignore) {}
        }
    } 
    finally {
        try { connection.close(); 
        } 
        catch (Exception ignore) {}

    }
}

Collectives™ on Stack Overflow

Java converting a cell to string

3 Answers 3

1 Comment

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related