excluding values from a foreach loop

Question

I have the following code.. and I know it's probably all wrong, but I haven't dealt with foreach loops before.

$last_names = regapiGetLastNames( NULL, -1 );
foreach ($last_names as $name => $last_name_id)
    $exclude = array('11196','11195','11198','11197');
    if(!in_array($name->last_name_id, $exclude)):
    print '<option value="'.$last_name_id.'">'.$name.'</option>';

Obviously its going wrong somewhere, any help pls?

put this on your page and post the results here. $last_names = regapiGetLastNames( NULL, -1 ); print_r($last_names); — Johnny Craig
– Johnny Craig, Commented Nov 17, 2011 at 22:50

mario · Accepted Answer · 2011-11-17 22:54:29Z

4

If the IDs are array values, then you can also use array_diff to filter them:

$last_names = regapiGetLastNames( NULL, -1 );

$exclude = array('11196','11195','11198','11197');
$last_names = array_diff($last_names, $exclude);

foreach ($last_names as $name => $last_name_id) {
    print '<option value="'.$last_name_id.'">'.$name.'</option>';
}

answered Nov 17, 2011 at 22:54

mario

146k20 gold badges243 silver badges293 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kai Qing · Accepted Answer · 2011-11-17 22:49:36Z

2

$last_names = regapiGetLastNames( NULL, -1 );
$exclude = array('11196','11195','11198','11197');
foreach ($last_names as $name => $last_name_id)
{
    if(!in_array($name->last_name_id, $exclude))
        print '<option value="'.$last_name_id.'">'.$name.'</option>';
}

You need the braces for a multiline loop. also, move the array declaration outside the loop

answered Nov 17, 2011 at 22:49

Kai Qing

18.9k6 gold badges41 silver badges61 bronze badges

4 Comments

Mike Purcell Over a year ago

This solution looks solid, although single line ifs without {} is bad practice imo.

Kai Qing Over a year ago

also, $name => $last_name_id looks like you can just call $last_name_id, but since you used $name->last_name_id I assumed you intended it this way. Maybe $name is an object. I don't know.

Kai Qing Over a year ago

yeah you can debate any non{} and in the end it is always bad practice I think. Just I wanted to show how he WOULD use it since his original had no braces.

Gary Over a year ago

This doesn't exclude the names.. they still show up in the select.

alex · Accepted Answer · 2011-11-17 22:49:18Z

0

You could turn that into...

$last_names = regapiGetLastNames( NULL, -1 );

$last_names = array_filter($last_names, function($value) {
    return in_array($value, array('11196','11195','11198','11197'));
});

foreach ($last_names as $name => $last_name_id) {
    print '<option value="'.$last_name_id.'">'.$name.'</option>';
}

When you get to doing your loop, you are only iterating over the set you want. This is useful for separating your business rules (dropping certain ids) and presentation (echoing the HTML).

answered Nov 17, 2011 at 22:49

alex

492k205 gold badges891 silver badges992 bronze badges

Comments

Nick D · Accepted Answer · 2011-11-17 22:51:08Z

0

I'd probably write it a little different this isn't correct ($name isn't an object)

$name->last_name_id

Something along the lines of:

$last_names = regapiGetLastNames( NULL, -1 );
$exclude = array('11196','11195','11198','11197');

foreach ($last_names as $name => $last_name_id) {
    if(!in_array($last_name_id, $exclude)) print '<option value="'.$last_name_id.'">'.$name.'</option>';
}

answered Nov 17, 2011 at 22:51

Nick D

5891 gold badge7 silver badges28 bronze badges

Collectives™ on Stack Overflow

excluding values from a foreach loop

4 Answers 4

Comments

4 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related