Bash - Input to a while loop

Question

#!/bin/bash

kommando="java -jar '/home/git/yuicompressor-2.4.7/build/yuicompressor-2.4.7.jar'"
gitdir='/home/git/repositories/gitosis-admin.git/gitosis-export/dev/www/res/'

echo "Vil Du versionere ? (ja/nej)"
read yesno
    if [yesno="ja"]
then
    echo "Hvad vil du kalde denne version:"
read version 
else
    echo "ok - surethang !"

while
  IFS=$'\n' read linje
do
  case "$linje" in
    *.css )
      $kommando "$gitdir/$linje" --type css >> "$gitdir/`basename \"$linje\" .css`."version".css" ;;
    *.js  ) 
      $kommando "$gitdir/$linje" --type js  >> "$gitdir/`basename \"$linje\" .js`."version".js" ;;
    ?*)
  esac 
done < manifest.conf

when i run the script it gives me and error at line 36 (end) (when i serve the manifest to the while loop).

Slava Semushin · Accepted Answer · 2011-12-05 10:03:29Z

3

I see following errors in your code:

you not enclose if statement by fi
missed spaces in if header
use $ when you wanted to get variable value

So, instead of

read yesno
if [yesno="ja"]
then
    echo "Hvad vil du kalde denne version:"
    read version 
else
    echo "ok - surethang !"

you should write

read yesno
if [ $yesno = "ja" ]
then
    echo "Hvad vil du kalde denne version:"
    read version 
else
    echo "ok - surethang !"
fi

answered Dec 5, 2011 at 10:03

Slava Semushin

15.2k7 gold badges56 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Michael Krelin - hacker · Accepted Answer · 2011-12-05 09:56:19Z

2

You have at least stray ?*) with no terminating ;;. Also, the [yesno="ja"] comaprison is wrong, you lost one dollar and due to the dollar shortage cut down on space program. Try [[ "$yesno" = "ja" ]] instead.

Otherwise description of the error might be helpful.

answered Dec 5, 2011 at 9:56

Michael Krelin - hacker

144k25 gold badges200 silver badges177 bronze badges

2 Comments

MsjComprendo Over a year ago

Could you explain a little further what you mean ?

Michael Krelin - hacker Over a year ago

Did you write the code yourself? What is ?*) supposed to mean? What is it supposed to do in this case?

Collectives™ on Stack Overflow

Bash - Input to a while loop

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related