Unexpected Behavior of a Static Function

Question

I'm working on a DX11 project, and I get an odd behavior with a static function. I'm a little uneducated about static functions, so I'm probably making a mistake somewhere.

My function is simple:

namespace Rendering
{
    static bool PlaceObjectInMatrix(EntityBase* obj, D3DXMATRIX world)
    {

        D3DXMatrixTranslation(&world, obj->GetPosition()->x, obj->GetPosition()->y, obj->GetPosition()->z); 
        return true;
    }
}

and it is called in a loop to render all the objects:

for(unsigned int i = 0; i < listSize; i++)
    {

        if(entities[i].taken == false)
            continue; 
        entities[i].entry->Render(deviceContext, shader);

        PlaceObjectInMatrix(entities[i].entry, worldMatrix);

        if(entities[i].entry->GetIndexCount() != 0) 
        {
            shader->Render(deviceContext, entities[i].entry->GetIndexCount(), worldMatrix, viewMatrix, projectionMatrix, entities[i].entry->GetTexture(), m_debugLight->GetDirection(), m_debugLight->GetDiffuseColor());
            objectsRendered++;
        }

        d3d->GetWorldMatrix(worldMatrix); //reset world matrix
    }

However, it does not work. When I replace the line with the function call with what is in the function itself, however, it does work. It's like something is getting lost in the function call.

The EntityBase class is abstract, and the class I'm actually rendering with is called EntityModelStatic, which is derived from EntityModel.

Since I really don't know much about Direct3D, this is only a suggestion: Make the world parameter a reference D3DXMATRIX& world. — Xeo
– Xeo, Commented Dec 12, 2011 at 2:33

Pavel Zhuravlev · Accepted Answer · 2011-12-12 02:38:06Z

2

The PlaceObjectInMatrix() function operates on worldMatrix copy. To change the original matrix you must declare the function like this:

static bool PlaceObjectInMatrix(EntityBase* obj, D3DXMATRIX& world);

More conventional way is to use pointers, like this:

static bool PlaceObjectInMatrix(const EntityBase& obj, D3DXMATRIX* world);

This way anyone reading the call code like PlaceObjectInMatrix(*entities[i].entry, &worldMatrix) will realize, that the function will change the worldMatrix object

answered Dec 12, 2011 at 2:38

Pavel Zhuravlev

2,8211 gold badge21 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ben Voigt · Accepted Answer · 2011-12-12 02:33:07Z

2

static bool PlaceObjectInMatrix(EntityBase* obj, D3DXMATRIX world)

The world argument is passed by value, so the function gets its own copy, and the variable in the caller is not changed. This is likely your problem.

Use a pointer (like D3DXMatrixTranslation) or a reference, and your problem will likely disappear.

answered Dec 12, 2011 at 2:33

Ben Voigt

286k45 gold badges444 silver badges764 bronze badges

Collectives™ on Stack Overflow

Unexpected Behavior of a Static Function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related