PHP is_array returning false?

Question

I have used is_array many times. The variable is an array, see my code, but when i use is_array function it returned false

Any Ideas?

Here is my code.

public function updateCategories($array = null)
{   
    echo gettype($array); // echos array
    if($array = null)
    {    
        return false;
    }    
    if(!is_array($array))
    {      
        echo "false"; // echos false
        return false;
    }

    foreach($array as $key => $val)
    {
        foreach($val as $Property => $Value)
        {
            if(!$this->updateCategoryProperty($key, $Property, $Value))
            {
                return false;
            }
        }
    }
}

Russell Dias · Accepted Answer · 2012-01-06 00:29:06Z

13

Your if($array = null) is not comparing, but assigning.

answered Jan 6, 2012 at 0:29

Russell Dias

73.9k5 gold badges58 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

M. of CA Over a year ago

WOOOOW i cant believe i missed that, i went over my code many times. Thank you very much.

Beto Aveiga Over a year ago

Exactly. Your editor should have pointed that for you. I use Netbeans, and it gives me a warning when I do assignments inside if statements. You should try it.

satrun77 Over a year ago

This is common mistake to avoid it write the if statement like this if(null == $array) so if you missed '=' php will throw syntax error

Stuck · Accepted Answer · 2014-09-28 12:31:32Z

1

Additionally to Russel Dias answer: always write your "null-checks" in this way:

if (null == $my_var)

now, if missing one "=", this will always get a real error, because you cannot assign something to null.

answered Sep 28, 2014 at 12:31

Stuck

12.5k13 gold badges76 silver badges124 bronze badges

1 Comment

coolpasta Over a year ago

Sorry for the necro, but why would my "null-checks" always be written this way? Why not empty( $my_var ) || !is_array( $my_var ), leaving the obvious fact that it's shorter.

Collectives™ on Stack Overflow

PHP is_array returning false?

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related