incrementing the values in an array based of another array

Question

I have a 2 dimensional 9 x 9 array (twoArray) that is filled with numbers between 1 & 17.
I am trying to create a one dimensional array (oneArray) that will provide me with the occurrence of the numbers in twoArray.

i.e. if the number ‘1’ appears ‘3’ times in the twoArray, then the value in oneArray[0] will be ‘3’, the number ‘15’ once, then oneArray[14] will be ‘1’, etc. I have the following code that I have written, but I am getting a ‘ArrayIndexOutOfBoundsException’

Not sure if my code is even correct for accomplishing this. Any guidance would be appreciated. I am not looking for the answer, just some advice so I can do it myself.

int[] oneArray= new int[17];
for (int i= 0; i< twoArray.length; i++)
{
    for (int j= 0; j< twoArray[j].length; j++) **// exception occurs here**
    {
        int num = 0;
        num = twoArray[i][j] - 1;
        oneArray[num] += 1;
    }
}

Sergey Kalinichenko · Accepted Answer · 2012-01-12 23:38:39Z

5

You have a typo: the condition should be j< twoArray[i].length, not j< twoArray[j].length. The rest of the program should work, but you may consider changing a couple of really small things:

Consider combining initialization of num with its calculation
Consider using ++ in place of += 1

answered Jan 12, 2012 at 23:38

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

NYC Canuck Over a year ago

Thank you. Don't know how I missed that!

JB Nizet · Accepted Answer · 2012-01-12 23:39:22Z

4

You need

for (int j= 0; j< twoArray[i].length; j++)
                           ^--i here, and not j

answered Jan 12, 2012 at 23:39

JB Nizet

694k94 gold badges1.3k silver badges1.3k bronze badges

Collectives™ on Stack Overflow

incrementing the values in an array based of another array

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related