Xml with two attributes in C#

Question

I want to make xml element like this:

<ElementName Type="FirstAttribute" Name="SecondAttribute">Value</Atrybut>

Now I'm doing this in this way:

XmlNode xmlAtrybutNode = xmlDoc.CreateElement("ElementName ");

_xmlAttr = xmlDoc.CreateAttribute("Type");
_xmlAttr.Value = "FirstAttribute";
xmlAtrybutNode.Attributes.Append(_xmlAttr);

_xmlAttr = xmlDoc.CreateAttribute("Name");
_xmlAttr.Value = "SecondAttribute";
xmlAtrybutNode.Attributes.Append(_xmlAttr);


xmlAtrybutNode.InnerText = !string.IsNullOrEmpty(Value) 
    ? SetTextLength(Name, ValueLength) 
    : string.Empty;

Value is input variable in method. Is there possibility to make this in another way? More efficiently? Can I use xmlWriter? Now i'm using xmlDocument.

if you are trying to serialize objects from your app take a look at XmlSerializer: msdn.microsoft.com/en-us/library/… — yas4891
– yas4891, Commented Jan 21, 2012 at 17:12
Why pretty broken? I'm doing this according to specification. I have sample xml output and I have to produce that xml. — GrzesiekO
– GrzesiekO, Commented Jan 21, 2012 at 17:19

parapura rajkumar · Accepted Answer · 2012-01-21 17:17:20Z

6

You can use Linq to XML.

Basically

        XDocument doc = new XDocument();
        doc.Add(
            new XElement("ElementName", "Value",
                new XAttribute("Type", "FirstAttribute"),
                new XAttribute("Name", "SecondAttribute")));

will give this xml document

<ElementName Type="FirstAttribute" Name="SecondAttribute">Value</ElementName>

answered Jan 21, 2012 at 17:17

parapura rajkumar

24.5k2 gold badges58 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marc Gravell · Accepted Answer · 2012-01-21 17:14:21Z

4

How about tweaking your existing code:

XmlElement el = xmlDoc.CreateElement("ElementName");
el.SetAttribute("Type", "FirstAttribute");
el.SetAttribute("Name", "SecondAttribute");
el.InnerText = ...;

Additional thoughts:

XElement
XmlSerializer (from a class instance)

answered Jan 21, 2012 at 17:14

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

Comments

Douglas · Accepted Answer · 2012-01-21 17:35:28Z

4

If you’re on .NET 3.5 (or later), you could use LINQ to XML. Make sure that the System.Xml.Linq assembly is referenced, and that you have a using directive for its eponymous namespace.

XDocument document = new XDocument(
    new XElement("ElementName",
        new XAttribute("Type", "FirstAttribute"),
        new XAttribute("Name", "SecondAttribute"),
        value));

If you subsequently want to write the XDocument to a target, you can use its Save method. For debugging, it’s useful to call its ToString method, which returns its XML representation as a string.

Edit: Replying to comment:

If you need to convert the XDocument created above into an XmlDocument instance, you may use code similar to the following:

XmlDocument xmlDocument = new XmlDocument();
using (XmlReader xmlReader = document.CreateReader())
    xmlDocument.Load(xmlReader);

edited Jan 21, 2012 at 17:35

answered Jan 21, 2012 at 17:16

Douglas

55.1k14 gold badges145 silver badges193 bronze badges

1 Comment

GrzesiekO Over a year ago

Can i add this document as appendChild to xmlDocument?

Crab Bucket · Accepted Answer · 2012-01-21 17:16:03Z

3

What about using LINQ to XML as in this article. That can be very elegant - it can all be done on one line.

 XDocument doc = new XDocument(
      new XDeclaration("1.0", "utf-8", "yes"),
      new XElement("element",
            new XAttribute("attribute1", "val1"),
            new XAttribute("attribute2", "val2"),
       )
);

answered Jan 21, 2012 at 17:16

Crab Bucket

6,2679 gold badges43 silver badges73 bronze badges

Collectives™ on Stack Overflow

Xml with two attributes in C#

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related