Javascript image loader

Question

I have this script that preloads a stack of images on my index page so that when people move on to my product page, the images are already in their cache. The problem is, when I remove the two alerts in the code so that it does not notify the user, the script won't work.

What am I doing wrong?

<script type="text/javascript">
  var imageFiles = new Array<?=$output?>
  var imagesLoaded = new Number(0);
  document.addEventListener("DOMContentLoaded", init, false);
  function init()
  {
    var images = new Array();

    alert("lkasd oe kdfl ke k");

    for(i=0; i<imageFiles.length; i++)
    images[i] = loadImage(imageFiles[i]);
  }
  function loadImage(url)
  {
    var image = new Image();
    image.addEventListener("load", imageLoaded, false);
    image.src = url;
    return image;
  }
  function imageLoaded()
  {
    imagesLoaded++;

    if (imagesLoaded == imageFiles.length)
      alert("Billederne er blevet preloadet og ligger i cachen.");
  }

</script>

I just can't believe that only 1 out of 11 answers was good enough so far. — jAndy
– jAndy, Commented Feb 8, 2012 at 16:48
Expanding on jAndy's comment: You should go back through your questions and mark the answers that solved your questions as Answered. People will be more likely to help you in the future if they see that you follow up. — Jason
– Jason, Commented Feb 8, 2012 at 16:49

Jason · Accepted Answer · 2012-02-08 16:46:08Z

9

I am guessing you didn't comment out your if as well as the alert.

We've had holy wars at my work about leaving off the { } for this very reason. =D

<script type="text/javascript">
  var imageFiles = new Array<?=$output?>
  var imagesLoaded = new Number(0);
  document.addEventListener("DOMContentLoaded", init, false);
  function init()
  {
    var images = new Array();

    //alert("lkasd oe kdfl ke k");

    for(i=0; i<imageFiles.length; i++)
    images[i] = loadImage(imageFiles[i]);
  }
  function loadImage(url)
  {
    var image = new Image();
    image.addEventListener("load", imageLoaded, false);
    image.src = url;
    return image;
  }
  function imageLoaded()
  {
    imagesLoaded++;

    //if (imagesLoaded == imageFiles.length)
    //  alert("Billederne er blevet preloadet og ligger i cachen.");
  }

</script>

answered Feb 8, 2012 at 16:46

Jason

11.6k24 gold badges80 silver badges134 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript image loader

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related