c# recursion folders and files directory

Question

I am trying to retrieve all the files in all the folders I have in a directory .

But the result is quite random ..

I think the foreach is wrong ..

What I don't understand is why ?

Because in all the folders , we check all the files and then display a link buttons of all the files . But actually it's displaying a lot of folders , twice .

 var DI = new DirectoryInfo("C://inetpub//wwwroot//ClientPortal//Files//")
              .GetDirectories("*.*", System.IO.SearchOption.AllDirectories);

 foreach (System.IO.DirectoryInfo D1 in DI)
 {
     System.IO.FileInfo[] fiArr = D1.GetFiles();

     foreach (System.IO.FileInfo file in fiArr)
     {
         LinkButton lktest = new LinkButton();
         lktest.Text = D1.Name;
         form1.Controls.Add(lktest);
         form1.Controls.Add(new LiteralControl("<br>"));
     }
 }

Can someone help me ?

Thanks a lot !

This kind of thing should be pretty easy to debug assuming you are in a position to attach a debugger... Just run through step by step and every time you are adding a new control inspect things to work out whether you are getting the right value and if not what things are not as you expect... — Chris
– Chris, Commented Feb 13, 2012 at 17:04

heisenberg · Accepted Answer · 2012-02-13 16:59:01Z

5

display a link buttons of all the files

Here you're creating link buttons with the name set to the directory when it sounds like you want the file instead (ie file.Name instead of D1.Name)

lktest.Text = D1.Name;

answered Feb 13, 2012 at 16:59

heisenberg

9,7691 gold badge32 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jeff Turner · Accepted Answer · 2012-02-13 16:56:54Z

2

Does this help?

http://www.dreamincode.net/code/snippet1669.htm

public void GetDirStructure(string path)
{
    try
    {
        DirectoryInfo dir = new DirectoryInfo(path);
        DirectoryInfo[] subDirs = dir.GetDirectories();
        FileInfo[] files = dir.GetFiles();
        foreach(FileInfo fi in files)
        {
            Console.WriteLine(fi.FullName.ToString());
        }

        if (subDirs != null)
        {
            foreach (DirectoryInfo sd in subDirs)
            {
                GetDirStructure(path + @"\\" + sd.Name);
            }
        }
    }
    catch(Exception ex)
    {
        Console.WriteLine(ex.Message.ToString());
    }
}

answered Feb 13, 2012 at 16:56

Jeff Turner

1,3578 silver badges13 bronze badges

Comments

Bernard · Accepted Answer · 2012-02-13 16:59:42Z

1

The first line of code seems like the culprit:

System.IO.DirectoryInfo[] DI = new System.IO.DirectoryInfo("C://inetpub//wwwroot//ClientPortal//Files//").GetDirectories("*.*", System.IO.SearchOption.AllDirectories);

Try using the following:

DirectoryInfo[] DI = new DirectoryInfo("C://inetpub//wwwroot//ClientPortal//File//").GetDirectories();

answered Feb 13, 2012 at 16:59

Bernard

7,9712 gold badges38 silver badges33 bronze badges

3 Comments

Bernard Over a year ago

The point is to use the correct overload of the DirectoryInfo.GetDirectories() method.

Austin Salonen Over a year ago

But why is the one OP is using wrong and your suggestion right?

Bernard Over a year ago

Because there is no need to specify search criteria. Have a look at the different method overloads here.

Collectives™ on Stack Overflow

c# recursion folders and files directory

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related