PHP adding to cart

Question

ATM, I'm testing my cart. When I load a new page with products to add to cart, they add add fine but i also get an error of for example:

Notice: Undefined index: cart_25 in

25 IS the index that is associated with the product.

  if (isset($_GET['add'])) {
   $_SESSION['cart_'.(int)$_GET['add']]+=1;
   }


   foreach($_SESSION as $name => $value) {
    if ($value>0){
     if (substr($name,0,5)=='cart_') {
       $name = substr($name, 5, (strlen($name)-5));
       echo $name.'<br />';
     }

Any tips to help would be great

As one of the answers below indicates, there's no need to cast the $_GET['add'] to an int, when you are going to concatenate it (as a string) to 'cart_' — msgmash.com
– msgmash.com, Commented Feb 22, 2012 at 18:01

aletzo · Accepted Answer · 2012-02-22 17:55:24Z

3

try it this way:

$key = 'cart_' . $_GET['add'];
$_SESSION[$key] = isset($_SESSION[$key]) ? $_SESSION[$key] + 1 : 1;

answered Feb 22, 2012 at 17:55

aletzo

2,4661 gold badge27 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Explosion Pills · Accepted Answer · 2012-02-22 18:05:32Z

1

Instead of using cart_{index} why don't you just make the array multiple dimensions? Then your foreach loop would be a lot simpler. You may also want to have functions or methods for adding and removing items so you don't have to do the same tests every time.

function add_to_cart($index, $amount) {
   if (!isset($_SESSION['cart'][$index])) {
      $_SESSION['cart'][$index] = 0;
   }
   $_SESSION['cart'][$index] += $amount;
}

answered Feb 22, 2012 at 18:05

Explosion Pills

192k56 gold badges341 silver badges417 bronze badges

Comments

Purag · Accepted Answer · 2012-02-22 18:00:03Z

0

$_SESSION['cart_'.(int)$_GET['add']]+=1; does $_SESSION['cart_'.(int)$_GET['add']] = **$_SESSION['cart_'.(int)$_GET['add']]** + 1; so first time it will be undefined, so

if (!isset($_SESSION['cart_'.(int)$_GET['add']])) {
    $_SESSION['cart_'.(int)$_GET['add'] = 1;
} else {
    $_SESSION['cart_'.(int)$_GET['add']]+=1;
}

edited Feb 22, 2012 at 18:00

Purag

17.1k4 gold badges57 silver badges78 bronze badges

answered Feb 22, 2012 at 17:57

Aurimas Ličkus

10.1k4 gold badges26 silver badges26 bronze badges

Collectives™ on Stack Overflow

PHP adding to cart

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related