Use function only once inside a foreach loop

Question

I have a MySQL DB field populated with some data. I have an option in my script which cleans that field so I can add new fresh data to it without appending to the old stuff.

However I am using a foreach loop which looks like this:

            foreach ($model->filenames as $key => $model->filename) {
            $model->get_title($model->filename);
            $model->get_showTitle($model->titles);
            $model->get_number($model->titles);
            $model->get_host($model->urls[$key]);
            $model->source_title($model->titles);
            $model->get_season();
            if ($model->show_exist_batch()) {
                $model->show_clean(); //the method in question
                $model->show_update();
            } else {
                $model->show_add();
                $model->twitter();
            }

The thing is that I want show_clean() to only run ONCE. This is how show_clean() looks:

    public function show_clean() {
    if ($this->options->clean) {
        $query = "UPDATE jos_k2_items SET extra_fields = '', extra_fields_search = '' WHERE id = " . $this->item->id . "";
        $this->db->prepare($query);
        $this->db->query();
    }
}

$this->option->clean is set by a post variable in the constructor.

Are there any clever ways of doing this or do i need to do it the long way?

Depends what you consider the »long way«. Simply have a bool variable that you check and set it once you've called the function. — knittl
– knittl, Commented Mar 4, 2012 at 21:21
Well I am actually rewriting an old script to object oriented and i did some funky coding to get it to work. That was the "long way" — Nick
– Nick, Commented Mar 4, 2012 at 21:34

drew010 · Accepted Answer · 2012-03-04 21:23:21Z

8

Not sure how "clever" this is, but its one way that doesn't seem to be long.

Set a variable outside of your loop indicating that you have not cleaned, and only call clean if it hasn't been set yet. Once you clean the first, time, set your flag so it will not clean again.

$cleaned = false;
foreach ($model->filenames as $key => $model->filename) {
    // ...
    if ($model->show_exist_batch()) {
        if (!$cleaned) {
            $model->show_clean();
            $cleaned = true;
        }
        $model->show_update();
    } else {
        // ...
    }
}

answered Mar 4, 2012 at 21:23

drew010

70.3k11 gold badges144 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nick Over a year ago

OF COURSE! I actually did it slightly different. I just changed the clean flag to false after the clean was complete inside the show_clean() method itself since the php script is still running

drew010 Over a year ago

That works too :) The art of programming are the many, many ways to solve the same problems.

Collectives™ on Stack Overflow

Use function only once inside a foreach loop

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related