Find and Replace all within nsstring

Question

I am trying to find list of words , if matches i am replacing. the blow code works but it is not replacing if the matching word occurs more than one time.

And i think i need to use while instead of if loop here , but i am not able to make it to work.

I am struggling Please let me know

    NSString *mymessage = @"for you for your information at you your at fate";

    NSMutableArray *full_text_list = [[NSMutableArray alloc]init];
    [full_text_list addObject:@"for"];
    [full_text_list addObject:@"for your information"];
    [full_text_list addObject:@"you"];
    [full_text_list addObject:@"at"];

    NSMutableArray *short_text_list = [[NSMutableArray alloc]init];
    [short_text_list addObject:@"4"];
    [short_text_list addObject:@"fyi"];
    [short_text_list addObject:@"u"];
    [short_text_list addObject:@"@"];

    for(int i=0;i<[full_text_list count];i++)
    {
        NSRange range = [mymessage rangeOfString:[full_text_list objectAtIndex:i]];

        if(range.location != NSNotFound) {
            NSLog(@"%@ found", [full_text_list objectAtIndex:i]);
            mymessage = [mymessage stringByReplacingCharactersInRange:range withString:[short_text_list objectAtIndex:i]];
        }


    }

see this may be help you :stackoverflow.com/a/9544264/1126111 — user1047415
– user1047415, Commented Mar 20, 2012 at 12:36

Dr.Kameleon · Accepted Answer · 2012-03-21 04:16:33Z

15

You don't have to reinvent the wheel; Cocoa does that for you...

Code :

NSString* message = @"for you for your information at you your at fate";

NSMutableArray* aList = [[NSMutableArray alloc] initWithObjects:@"for your information",@"for",@"you ",@"at ",nil];
NSMutableArray* bList = [[NSMutableArray alloc] initWithObjects:@"fyi",@"4",@"u ",@"@ ",nil];

for (int i=0; i<[aList count];i++)
{
    message = [message stringByReplacingOccurrencesOfString:[aList objectAtIndex:i] 
                                                 withString:[bList objectAtIndex:i]];
}

NSLog(@"%@",message);

HINT : We'll be replacing each and every one occurence of aList[0] with bList[0], aList[1] with bList[1], and so on... ;-)

edited Mar 21, 2012 at 4:16

answered Mar 20, 2012 at 12:15

Dr.Kameleon

22.8k21 gold badges124 silver badges241 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

user198725878 Over a year ago

Thanks for the reply but for your information is not replaced as fyi it replaced as inform@ion. Any thoughts?

Dr.Kameleon Over a year ago

I just edited the code above... there was a tiny mistake ("result" instead of "message"). It should be working now...

Dr.Kameleon Over a year ago

@user198725878 I didn't get that : WHAT was replaced with WHAT?

user198725878 Over a year ago

the text 'for your information' is not replaced as fyi it replaced as '4 ur inform@ion'. Any thoughts?

Dr.Kameleon Over a year ago

Well.. that's because "for" is higher up in the list, than "for your information"... that's why... If "for your information" (as it is a "superset" of other searches) and "fyi" are placed as the FIRST object of the arrays, it'll work... ;-)

|

wbyoung · Accepted Answer · 2012-03-20 12:13:37Z

3

Look at NSString's stringByReplacingOccurrencesOfString:withString: method.

answered Mar 20, 2012 at 12:13

wbyoung

22.5k2 gold badges36 silver badges41 bronze badges

Comments

iOS_Developer · Accepted Answer · 2012-03-20 12:41:37Z

2

Your string (myMessage) contains "for" word 3 times. When the for loop is executing first times it is replacing the "for" with "4", After first execution of for loop your string become like "4 you 4 your in4mation at you your at fate". Because "for your information" has become "4 your in4mation". It has replaced the third "for" also.

Same way it is replacing "at" also from "in4mation" word and becoming like "in4m@ion", And finally you are getting a new string like "4 u 4 ur in4m@ion @ u ur @ f@e".

My English is not so good, I hope you got my point.

answered Mar 20, 2012 at 12:41

iOS_Developer

1838 bronze badges

Collectives™ on Stack Overflow

Find and Replace all within nsstring

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related