Skip to content

Conversation

@christophejunke
Copy link
Contributor

Related to quicklisp/quicklisp-projects#685 and quicklisp/quicklisp-projects#728.

When making a release tarball, add a temporary submodules/ directory
and create archives for all submodules, using git submodules foreach
calling git archive HEAD. Concatenate the resulting archives
into the main one.

I tested by running:

(make-release-tarball 
 (make-instance 'git-source
                :project-name "cl-ledger"
                :location "https://github.com/ledger/cl-ledger")
 #P"/tmp/test.tgz")

I also let ensure-what-wins-you-can run for a while to see if projects
without submodules were still building.

NB. It could be the case that a submodule is another system already registered in ASDF,
possibly from another version (for example, the submodule points to a previous release).
I am not sure if this is a problem and what should be in done in that case.

When making a release tarball, add a temporary submodules/ directory
and create archives for all submodules, using "git submodules foreach".
Concatenate the resulting archives into the main one.
@quicklisp quicklisp merged commit 8e2cbdb into quicklisp:master Feb 5, 2018
@quicklisp
Copy link
Owner

This caused me a bunch of trouble, so I've reverted it for now.

@christophejunke
Copy link
Contributor Author

I understand; I will try to test that more. Do you have more details about what goes wrong?

@quicklisp
Copy link
Owner

quicklisp commented Feb 7, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants