Symfony 2: Dependency injection (DI) of Controllers

Question

Is there any chance to make Controllers dependent on their services not via using of service container inside them but through pure constructor dependency injection?

I would like to write controllers in this way:

<?php

class ArticleController extends \Symfony\Bundle\FrameworkBundle\Controller\Controller
{
    private $articleFacade;
    private $articleRepository;

    public function __construct(ArticleFacade $articleFacade, ArticleRepository $articleRepository)
    {
        $this->articleFacade = $articleFacade;
        $this->articleRepository = $articleRepository;
    }

    public function indexAction()
    {
        ...
    }

}

Unfortunatelly as I can see Symfony ControllerResolver does new instances of Controllers not via ServiceContainer but via simple return new $controller call.

Cerad · Accepted Answer · 2012-04-11 12:57:22Z

12

Absolutely in fact it's recommended and if you look at most 3rd party bundles such as FOSUser you can see that that is exactly what they do.

The trick is to define your controllers as services and then use the service id instead of the class name.

http://symfony.com/doc/current/cookbook/controller/service.html

Keep in mind that you will have to inject all your needed services such as entity managers and you won't usually extend the symfony base class. Of course you could inject the complete container but that tends to be frowned on.

answered Apr 11, 2012 at 12:57

Cerad

49k9 gold badges92 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Elnur Abdurrakhimov Over a year ago

Take a look at my AbstractControllerBundle. It's meant to provide you with a parent service to simplify using controllers as services.

Steve Over a year ago

It doesn't look to me like FOSUser does this? Am I missing the point? Václav's question was about injecting them via the constructor method, whilst FOSUser does $this->container->get('service'); github.com/FriendsOfSymfony/FOSUserBundle/blob/master/…

rybo111 Over a year ago

in fact it's recommended - according to the official documentation: "Defining controllers as services is not officially recommended by Symfony"

Cerad Over a year ago

@rybo111 True though when I wrote this answer 5+ years ago the Symfony best practices document did not exist. And if you look at dependency injection vs service locator debates then dependency injection generally wins out. But what is interesting and relevant for today is that Symfony 4 defines controllers as services by default. The wheel turns.

Collectives™ on Stack Overflow

Symfony 2: Dependency injection (DI) of Controllers

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related