Checkboxes values in mysql db

Question

Whats the problem with below code.Error Warning: Invalid argument supplied for foreach()

    if(isset($_POST['submit']))
        {
        foreach($_POST['team[]'] as $value)
        {
        $insert=mysql_query("INSERT INTO team('team') VALUES ('$value')");
        }
        if($insert)
        {
        echo "dONE";
        }
        }
<form method="post" action="check.php">
<input type="checkbox" name="team[]" value="AG"> Argentina
<input type="checkbox" name="team[]" value="GE"> Germany
<input type="checkbox" name="team[]" value="BR"> Brazil
<input type="submit" name="submit" value="submit">
</form>

I think you should use foreach($_POST['team'] as $value)

Marco
– Marco

2012-07-31 15:32:15 +00:00
Commented Jul 31, 2012 at 15:32 — Marco
– Marco, Commented Jul 31, 2012 at 15:32

j0k · Accepted Answer · 2012-07-31 15:28:07Z

2

Try with:

foreach($_POST['team'] as $value)

answered Jul 31, 2012 at 15:28

j0k

22.8k28 gold badges81 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

j0k Over a year ago

Are you sure? Have you tried? Just test it on my localhost and it works.

FAIQ NASEEM Over a year ago

Invalid argument supplied for foreach()

FAIQ NASEEM Over a year ago

can you give share the whole code,with db connection.i want to test in my localhost also.Kindly

j0k Over a year ago

Well, my answer solve the error you describe in your question. But it seems that you have others errors now. You have 2 options: update this question with more information about new errors (and the code that provide these errors) or post a new question with new errors.

Matt · Accepted Answer · 2012-07-31 15:28:28Z

1

Don't refer to team[]. Instead use

if (isset($_POST['team'])) {
    foreach($_POST['team'] as $value) { ... }
}

answered Jul 31, 2012 at 15:28

Matt

7,0504 gold badges31 silver badges50 bronze badges

3 Comments

FAIQ NASEEM Over a year ago

Invalid argument supplied for foreach()

Matt Over a year ago

@FAIQNASEEM is $_POST['team'] set?

Matt Over a year ago

@FAIQNASEEM do a var_dump() on $_POST and see what it contains when you submit the form.

Hipny · Accepted Answer · 2012-07-31 15:36:16Z

1

When you will receive from the $_POST the variable team, it will be an array of every checkbox.

So instead of using team[] you should use

foreach($_POST['team'] as $value)

Also, you should be aware that if no checkbox were checked, the key team will not exist, so make sure before your foreach to do a if (isset($_POST['team']))

also you are overwriting insert at every time you loop.

you may want to do something like this :

if(isset($_POST['submit']))
{
    if (isset($_POST['team']))
    {
        $insert = true;

        foreach($_POST['team'] as $value)
        {
            // we add security with mysql_real_escape_string
            $value = mysql_real_escape_string($value);
            $result = mysql_query("INSERT INTO team('team') VALUES ('$value')");

            if (!$result)
            {
                $insert = false;
                break;
            }
        }

        if($insert)
        {
            echo "dONE";
        }
    }
}

you may want to check mysql_real_escape_string to add secrurity to your code

edited Jul 31, 2012 at 15:36

answered Jul 31, 2012 at 15:30

Hipny

7491 gold badge11 silver badges24 bronze badges

1 Comment

Hipny Over a year ago

@FAIQNASEEM Depending of what data you want to store into your database, yes this is enough.

Lee · Accepted Answer · 2012-07-31 15:28:44Z

0

when you do name=something[] on an input, php will create the array for you so you just need to do

foreach($_POST['team'] as $value)

Also something like name=team[member][] could be iterated through in php like so

foreach($_POST['team']['member'] as $value)

So it makes grouping inputs and well as processing multiple dynamic inputs very easy

answered Jul 31, 2012 at 15:28

Lee

10.6k4 gold badges39 silver badges45 bronze badges

1 Comment

FAIQ NASEEM Over a year ago

Invalid argument supplied for foreach()

Jose Vega · Accepted Answer · 2012-07-31 15:42:43Z

0

Try the following:

$teams = $_POST['team'];
$submitted = $_POST['submit'];

if(isset($submitted) && is_array($teams)) {

     foreach($teams as $team) {
          /* Escapes special characters in a string for use in an SQL statement */ 
          $team = mysql_real_escape_string($team)
          $insert = mysql_query("INSERT INTO team('team') VALUES ('$team')");
     }

     if($insert) {
          echo "dONE";
    }
} else {
    echo "Either Form Not Submitted or Teams is Not Array";
}

edited Jul 31, 2012 at 15:42

answered Jul 31, 2012 at 15:30

Jose Vega

10.3k7 gold badges43 silver badges58 bronze badges

4 Comments

FAIQ NASEEM Over a year ago

Invalid argument supplied for foreach()

Jose Vega Over a year ago

If you are still getting "Invalid argument supplied foreach()", try my revised answer.

FAIQ NASEEM Over a year ago

Either Form Not Submitted or Teams is Not Array,this is printed on page

Jose Vega Over a year ago

right before the if statement, try print_r($_POST['team']) does that show you the values you checked?

Collectives™ on Stack Overflow

Checkboxes values in mysql db

5 Answers 5

4 Comments

3 Comments

1 Comment

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

3 Comments

1 Comment

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related