Recursion stackOverflowError when finding empty cells in Minesweeper game

Question

EDIT: SOLVED! I simply forgot to include an 'else' statement under the 'else if' which does a blank return

I'm using Java, and I'm making a Minesweeper game.

I am trying to open all adjacent empty cells when an empty cell is clicked. I have taken a look at similar question on this site and can't see where I'm going wrong. I am getting a stackOverflow.

Any help will be greatly appreciated.

Below, the 'buttons' array is a 2D array of buttons, and the 'cells' array is a 2D array of cell objects (used to determine the state of that cell). Obviously each cell corresponds to a button.

public void findEmptyCells(int i, int j) // this method is called when a cell is clicked, therefore all adjacent empty cells will be opened
{
    if (i >= 0 && j >= 0 && i < 9 && j < 9) //ie the block actually exists on the grid
    {
        if (cells[i][j].getAdjMines() == 0 && cells[i][j].getIsMine() == false && cells[i][j].getIsFlagged() == false && cells[i][j].getIsOpen() == false) //if cell is empty & not a mine & not flagged
        {
            buttons[i][j].setIcon(new ImageIcon("buttonImages/but" + cells[i][j].getAdjMines() + ".png")); //here the getAdjMines value will be 0, so the empty cell icon will be placed
            cells[i][j].setIsOpen(true); //for later, if we need to identify which cells are still unclicked

            //now to check all adjacent cells
            findEmptyCells(i - 1, j); //left 
            findEmptyCells(i + 1, j); //right 
            findEmptyCells(i, j + 1); //up
            findEmptyCells(i, j - 1); //down
            findEmptyCells(i - 1, j + 1); //up-left
            findEmptyCells(i + 1, j + 1); //up-right
            findEmptyCells(i - 1, j - 1); //down-left
            findEmptyCells(i + 1, j - 1); //down-right

        }
        else if (cells[i][j].getAdjMines() > 0)
        {
            buttons[i][j].setIcon(new ImageIcon("buttonImages/but" + cells[i][j].getAdjMines() + ".png"));
            cells[i][j].setIsOpen(true); //for later, if we need to identify which cells are still unclicked
            return;
        }

    }
    else
    {
      return;  
    }
}

Joe K · Accepted Answer · 2012-09-05 18:09:14Z

2

Make sure your getIsOpen and setIsOpen methods are working as intended. Those are the ones that are key to stopping recursion, so my guess is that there's something wrong there.

answered Sep 5, 2012 at 18:09

Joe K

18.5k2 gold badges42 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Recursion stackOverflowError when finding empty cells in Minesweeper game

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related