Fatal error: Method name must be a string

Question

I'm getting error:

Fatal error: Method name must be a string in C:\xampp\htdocs\index.php on line 15"

LINE 15:

$obj = new $url[0]();

CODE:

<?php
error_reporting(E_ALL ^ E_NOTICE);

$url = $_GET['url'];
$url = explode('/', $url);

if (!file_exists('controllers/' . $url[0] . '.php')) {
    $url[0] = 'error';   // error kontroleris 
}    
require 'controllers/' . $url[0] . '.php';

$obj = new $url[0]();
$obj->$url[1]();

BTW.: Script is not finished yet.

What version of PHP is this?

Philip Whitehouse
– Philip Whitehouse

2012-11-08 17:56:20 +00:00
Commented Nov 8, 2012 at 17:56 — Philip Whitehouse
– Philip Whitehouse, Commented Nov 8, 2012 at 17:56

raina77ow · Accepted Answer · 2012-11-08 17:59:14Z

2

Actually, this syntax:

$urls = array('DOMDocument');
$dom = new $urls[0]('');
var_dump( $dom );

... is valid even in PHP 5.2 (proof). But this line...

$obj->$url[1]();

... is pretty damn able (another proof) to throw exactly the same error as you've shown, as you don't check for url array length anywhere in your code.

edited Nov 8, 2012 at 17:59

answered Nov 8, 2012 at 17:48

raina77ow

107k16 gold badges205 silver badges240 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Samuel Cook · Accepted Answer · 2012-11-08 19:05:20Z

0

$_GET['url'] = 'foo/bar'; // temp set $_GET
$url = $_GET['url'];
$url = explode('/', $url);

if (file_exists('controllers/' . $url[0] . '.php')){
    require 'controllers/' . $url[0] . '.php';
}else{
    $url[0] = 'error'; 
}

$obj = new URL;
if(method_exists($obj,$url[0])){ // test that method exists
    echo $obj->$url[0](); // or whatever your handling may be
}

class URL{
    public function error(){
        $return = 'this is for the error handling';
        return $return;
    }
}

edited Nov 8, 2012 at 19:05

answered Nov 8, 2012 at 17:50

Samuel Cook

16.9k7 gold badges56 silver badges65 bronze badges

6 Comments

user1810078 Over a year ago

Now it says that there is an empty property and it cannot access it :/

Samuel Cook Over a year ago

are you ensuring that your using $obj->url and not $obj->$url

user1810078 Over a year ago

And then it says that function name must be a string :D

Samuel Cook Over a year ago

I've made some edits to the code, on the basis of what i think your trying to achieve

user1810078 Over a year ago

Now it just says "this is for the error handling" But it should display the code from two echo'ed controllers Maybe you have skype ? I would contact you

|

Collectives™ on Stack Overflow

Fatal error: Method name must be a string

2 Answers 2

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related