else statement not working. how to close loop when nothing is entered?

Question

else statement not working. how to close loop when nothing is entered? suggestions on how to approach?

def main():
    print "~*~*~*~*~*~ Timbuktu Archery Contest ~*~*~*~*~*~"
    archerList = [] #list
    timeList = [] #list2
    name = raw_input ("Enter contestants first name: ")
    s = str(name)
    archerList.append(name)
    while name > 0:
        time = raw_input ("Enter time (in milliseconds) for %s: " % s)
        timeList.append(time)
        name = raw_input ("Enter contestants first name: ")
        s = str(name)
        archerList.append(name)
    else:
        name == ""
        print "Slowest archer was " , min(timeList)
        print "Fastest archer was " , max(timeList)

raw_input takes the input as string, what do you get by doing > 0 with it? If you want a number from the raw_input, better cast it to int... — NedStarkOfWinterfell
– NedStarkOfWinterfell, Commented Feb 15, 2013 at 7:55
And if you are reading a number, you should probably first change the variable name from name to something that really signifies holding a nnumeric vcalue. — Rohit Jain
– Rohit Jain, Commented Feb 15, 2013 at 7:56

Janne Karila · Accepted Answer · 2013-02-15 07:58:06Z

2

To loop until an empty name is given:

while name:

answered Feb 15, 2013 at 7:58

Janne Karila

25.3k6 gold badges59 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arpit · Accepted Answer · 2013-02-15 08:00:16Z

0

You need this:

while len(name) > 0

answered Feb 15, 2013 at 8:00

Arpit

12.8k3 gold badges29 silver badges40 bronze badges

Comments

avimehenwal · Accepted Answer · 2013-02-15 10:22:54Z

0

You can escape from loop if nothing is entered by using this if-else construct

if (name==''):
    break
else:
    <job to be done>

edited Feb 15, 2013 at 10:22

answered Feb 15, 2013 at 10:13

avimehenwal

1,5923 gold badges21 silver badges31 bronze badges

1 Comment

Duncan Over a year ago

In Python you can have if...else, for...else, while...else, try...else.

Rich Tier · Accepted Answer · 2013-02-15 13:09:58Z

0

this is more pythonic. DRY = Dont Repeat Yourself.

def main():
    print "~*~*~*~*~*~ Timbuktu Archery Contest ~*~*~*~*~*~"
    min = max = 0
    while True:
        name = raw_input ("Enter contestants first name: ")
        if not name:
            break
        start = raw_input ("Enter time (in milliseconds) for %s: " % name)
        min = start if start < min else min
        max = start if start > max else max
    print "Slowest archer was %i" % min
    print "Fastest archer was %i" % max

points to consider:

I removed archerList as you don't get values from it in your code
what happens if archers achieve the same time?
the "slowest archer was..." actually tells us the slowest archer's time, not their name

edited Feb 15, 2013 at 13:09

answered Feb 15, 2013 at 13:00

Rich Tier

9,53910 gold badges51 silver badges74 bronze badges

Collectives™ on Stack Overflow

else statement not working. how to close loop when nothing is entered?

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related