PHP Loop, Add a comma after every loop except the last

Question

I've got a query that loops through some product names and puts them down on the page. As part of the loop, it adds a comma to the end, so it looks like this:

Products: Shirts, Pants, Ties, Jackets,

Notice that I'm getting a comma after the last product. Also, they are all links, so I can't use some strreplace fx or similar:

Here's my code:

<?php
 $product_query = mysql_query("select * from products_table);
 $row_product_query = mysql_fetch_assoc($product_query);
 $totalRows_product_query = mysql_num_rows($product_query);
 ?>
 <strong>Products:  </strong>
 <?php if ($totalRows_product_query > 0) {  ?>
 <?php do { ?>
 <span><a href="link"><?php echo $row_product_query['products_name']; ?></a></span>
<strong>,&nbsp;</strong>
 <?php } while ($row_product_query = mysql_fetch_assoc($product_query)); ?>
 <?php } ?><br />

What do I need to do to make that last comma not appear?

Thanks in advance as always.

Add it to a variable, and do substr to remove the last comma. — Antony
– Antony, Commented Feb 15, 2013 at 19:34
Print the first link outside of the loop, then each additional link inside the loop with a comma proceeding it — Steve's a D
– Steve's a D, Commented Feb 15, 2013 at 19:37
@Tucker, perhaps post that as an answer since it is probably the "correct" solution — drone-ah
– drone-ah, Commented Feb 15, 2013 at 19:40
i think you only need check if is the last row , do not print comma , no need to change all your code , i write my answer — Ali Akbar Azizi
– Ali Akbar Azizi, Commented Feb 15, 2013 at 20:00

Antony · Accepted Answer · 2013-02-15 19:47:42Z

2

using the php implode function

<?php
    $str = "";
    $product_query = mysql_query("select * from products_table");
    $row_product_query = mysql_fetch_assoc($product_query);
    $totalRows_product_query = mysql_num_rows($product_query);
    $cnt = 0;
?>
<strong>Products:  </strong>
<?php if ($totalRows_product_query > 0) {  ?>
<?php do { 
    $arr[$cnt] = '<span><a href="link">'.$row_product_query['products_name'].'</a></span>';
    $cnt++;
<?php } while ($row_product_query = mysql_fetch_assoc($product_query)); ?>
<?php } 
    echo implode("<strong>,</strong>",$arr);
?><br />

edited Feb 15, 2013 at 19:47

Antony

15.2k10 gold badges48 silver badges76 bronze badges

answered Feb 15, 2013 at 19:41

Tucker

7,38210 gold badges40 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Kevin Over a year ago

Thanks Tucker (and everybody else)

Brad Bonkoski · Accepted Answer · 2013-02-15 19:35:21Z

0

Fix how they are being stored/entered into the database? otherwise, <?php echo str_replace(",", "", $row_product_query['products_name']); ?> should work

answered Feb 15, 2013 at 19:35

Brad Bonkoski

765 bronze badges

1 Comment

Damien Pirsy Over a year ago

Commas are added during the loop, they're not stored in DB puts them down on the page. As part of the loop, it adds a comma to the end,

SchautDollar · Accepted Answer · 2013-02-15 19:40:32Z

0

As @tucker said, you could use the implode function. Implode Function. You would use it with an array like so

$a_string = implode(",",$the_result_array);

This would give you your desired results.

answered Feb 15, 2013 at 19:40

SchautDollar

3483 silver badges13 bronze badges

Collectives™ on Stack Overflow

PHP Loop, Add a comma after every loop except the last

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related