Space remove from String

Question

#include<stdio.h>
#include<string.h>

int main(){
    char array[]="Arijit Saha Student";
    spaceremover(array);
    getch();
    return 1;
}

int spaceremover(char a[]){
    int i;
   // printf("L=%d",strlen(a));
    char final[strlen(a)+1];
    int count=0;
    for(i=0;i<strlen(a);i++)
    {
        if(a[i]!=' ')
            final[count]=a[i];
        count++;
    }
    final[count]='\0';
    int j=0;
    for(j=0;j<strlen(final);j++)
    printf("%c",final[j]);
    // printf("\n%s",final);
    return 1;
}

With this example code the output is Arijit.Saha, but my desired output is ArijitSahaStudent. Why am I getting the wrong output? Where the . is coming from?

@VladLazarenko Really? I thought SO is for programming issues and CR is for reviewing code. Then what kind of questions belong here? — Bernhard Barker
– Bernhard Barker, Commented Mar 4, 2013 at 16:30
The '.' is probably just junk data leftover from something else. Your biggest problem is that count is being incremented no matter what. You should put curly braces around final[count]=a[i]; and count++ so count only increments when a letter is added to the array. Currently, when it gets to a space, nothing is added to the final array at that position — jonhopkins
– jonhopkins, Commented Mar 4, 2013 at 16:30

Klas Lindbäck · Accepted Answer · 2013-03-04 16:30:47Z

6

The error is here:

if(a[i]!=' ')
    final[count]=a[i];
count++;

The count++ should be included in the if, so:

if(a[i]!=' ') {
    final[count]=a[i];
    count++;
}

Note: It is considered good programming practice to always use curly braces after if statements.

answered Mar 4, 2013 at 16:30

Klas Lindbäck

33.4k5 gold badges61 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

LihO Over a year ago

+1 nice spotted. It just shows how important is the proper indentation of the code.

Grijesh Chauhan · Accepted Answer · 2013-04-11 15:00:07Z

2

In the for loop you increase count even if a[i] == ' ' .
So when a[i] == ' ' you only increase count but doesn't set final[count] to anything.

I assume you ment to write:

if (a[i] != ' ')
{
    final[count] = a[i];
    count++;
}

edited Apr 11, 2013 at 15:00

Grijesh Chauhan

58.6k20 gold badges145 silver badges214 bronze badges

answered Mar 4, 2013 at 16:34

the_jk

5992 silver badges10 bronze badges

Comments

spartacus · Accepted Answer · 2013-03-04 16:32:23Z

0

You are not incrementing count correctly. It needs to be in the if loop. This might be easier for you to see if things are indented correctly.

#include<stdio.h>
#include<string.h>

int main(){
  char array[]="Arijit Saha Student";
  spaceremover(array);
  return 1;
}

int spaceremover(char a[]){
  int i;
  // printf("L=%d",strlen(a));
  char final[strlen(a)+1];
  int count=0;
  for(i=0;i<strlen(a);i++)
  {
    if(a[i]!=' ')
      final[count++]=a[i];
  }
  final[count++]='\0';
  int j=0;
  for(j=0;j<strlen(final);j++)
    printf("%c",final[j]);
  // printf("\n%s",final);
  return 1;
}

answered Mar 4, 2013 at 16:32

spartacus

6136 silver badges12 bronze badges

Comments

dclink · Accepted Answer · 2013-03-04 17:12:58Z

0

In the loop, the count should increase if a[i] not equal to space

if(a[i]!=' ') final[count]=a[i]; count++;

if(a[i]!=' ')
final[count++]=a[i];
//count++;

answered Mar 4, 2013 at 17:12

dclink

134 bronze badges

Collectives™ on Stack Overflow

Space remove from String

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related