maximum recursion depth exceeded on Django model when creating

Question

I have this strange problem with one of my Django models and I was able to fix it but don't understand what is happening.

These are the models:

class Player(models.Model):
    facebook_name = models.CharField(max_length=100)
    nickname = models.CharField(max_length=40, blank=True)

    def __unicode__(self):
        return self.nickname if self.nickname else self.facebook_name


class Team(models.Model):
    name = models.CharField(max_length=50, blank=True)
    players = models.ManyToManyField(Player)

    def __unicode__(self):
        name = '(' + self.name + ') ' if self.name else ''
        return name + ", ".join([unicode(player) for player in self.players.all()])

Whenever I make a new (empty) Team object and want to get players from it, I got a RuntimeError: maximum recursion depth exceeded. For example:

>>> team = Team()
>>> team.players
    Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/Users/walkman/Projects/fociadmin/venv/lib/python2.7/site-packages/django/db/models/fields/related.py", line 897, in __get__
    through=self.field.rel.through,
  File "/Users/walkman/Projects/fociadmin/venv/lib/python2.7/site-packages/django/db/models/fields/related.py", line 586, in __init__
    (instance, source_field_name))
  File "/Users/walkman/Projects/fociadmin/venv/lib/python2.7/site-packages/django/db/models/base.py", line 421, in __repr__
    u = six.text_type(self)
  File "/Users/walkman/Projects/fociadmin/fociadmin/models.py", line 69, in __unicode__
    return name + ", ".join([unicode(player) for player in self.players.all()])
  File "/Users/walkman/Projects/fociadmin/venv/lib/python2.7/site-packages/django/db/models/fields/related.py", line 897, in __get__
    through=self.field.rel.through,
  File "/Users/walkman/Projects/fociadmin/venv/lib/python2.7/site-packages/django/db/models/fields/related.py", line 586, in __init__
    (instance, source_field_name))
  File "/Users/walkman/Projects/fociadmin/venv/lib/python2.7/site-packages/django/db/models/base.py", line 421, in __repr__
    u = six.text_type(self)
  File "/Users/walkman/Projects/fociadmin/fociadmin/models.py", line 69, in __unicode__
    return name + ", ".join([unicode(player) for player in self.players.all()])
...

Why is this happening? I was able to fix it by checking for pk and only generate the name then, but what I think it should work the way is returning only the name because ", ".join... would be an empty list. Instead, some recursion occurs which I don't understand.

knbk · Accepted Answer · 2013-08-01 10:20:08Z

21

+50

The problem is that you can't access the team.players field when the Team instance is not yet saved to the database. Trying to do this will raise a ValueError.

However, while trying to raise this ValueError, the code will try to get a representation of your team object which will indirectly call unicode(team). This will try to access self.players, which will try to raise another ValueError before the first one is raised. This goes on until the maximum recursion depth is reached, but there is still no ValueError thrown. Therefore, you'll only see the RuntimeError.

The same would (should?) happen if you did either of the following:

>>> team
>>> repr(team)
>>> unicode(team)

edited Aug 1, 2013 at 10:20

answered Jul 27, 2013 at 16:05

knbk

53.9k9 gold badges130 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

AndrewS Over a year ago

Accessing the many-to-many relationship before the instance is saved will raise a ValueError and lead to the scenario described. If the instance is saved (and has a primary key) then the relationship would be an empty list.

knbk Over a year ago

@AndrewS You're right, updated my answer. Thanks for noticing!

Collectives™ on Stack Overflow

maximum recursion depth exceeded on Django model when creating

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related