How to count occurances of strings in given string wothout using a predefined string functions?

Question

Here is the small snippet to count the string occurrences of string without using string functions.

  <?php

$str ='1234567891222222222233333332';
$count = 0;
$ones='';
$twos='';
$threes='';

while(isset($str[$count])){
//echo $str[$count];

if($str[$count]== 1)
$ones += count($str[$count]);

if($str[$count]== 2)
$twos += count($str[$count]);

if($str[$count]== 3)
$threes += count($str[$count]);

++$count;
}
echo 'total number of 1\'s = '.$ones.'<br/>';
echo 'total number of 2\'s = '.$twos.'<br/>';
echo 'total number of 3\'s = '.$threes.'<br/>';
?>

Please can anyone shorter the code in efficient way...

Austin Brunkhorst · Accepted Answer · 2013-09-07 09:33:34Z

2

You can do this. I'm not sure why you're using count(), as you can just increment it.

$count = 0;
$countSizes = array();

while(isset($str[$count++])) {
    $countSizes[ $str[$count] ]++;
}

$countSizes will now have the count of each number in the string respective to its index.

answered Sep 7, 2013 at 9:33

Austin Brunkhorst

21.1k6 gold badges49 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jonathan Wren Over a year ago

Be careful not to increment $count in the while condition, since this will cause your array index to not line up with the actual results. This should read: while(isset($str[$count])) { $countSizes[ $str[$count++] ]++; } instead

Bora · Accepted Answer · 2013-09-07 09:35:26Z

2

You can use array_count_values and str_split if your numbers range 0-9

$result = array_count_values(str_split($str));

Output

var_dump($result);

array (size=9)
  1 => int 2
  2 => int 12
  3 => int 8
  4 => int 1
  5 => int 1
  6 => int 1
  7 => int 1
  8 => int 1
  9 => int 1

answered Sep 7, 2013 at 9:35

Bora

10.7k5 gold badges50 silver badges76 bronze badges

Comments

Salketer · Accepted Answer · 2013-09-07 09:33:22Z

0

for($i=1;$i<=3;$i++){
    preg_match_all ( $strn , $i, $matches);
    //preg_match_all stores the found values in $matches, you can count them easily...
    echo 'There is '.count($matches).' "'.$i.'".';
}

answered Sep 7, 2013 at 9:33

Salketer

15.8k2 gold badges32 silver badges64 bronze badges

Comments

Mark Baker · Accepted Answer · 2013-09-07 09:42:48Z

0

sounds like homework to me:

$counters = array_fill(0,10,0);
$count = 0;
while(isset($str[$count])){
    $counters[$str[$count++]]++;
}
foreach($counters as $key => $value) {
    echo "Total number of {$key}s = {$value}", PHP_EOL;
}

or even using

array_count_values(str_split($str));

if str_split() is permitted

edited Sep 7, 2013 at 9:42

answered Sep 7, 2013 at 9:30

Mark Baker

213k34 gold badges354 silver badges390 bronze badges

Comments

MD SHAHIDUL ISLAM · Accepted Answer · 2013-09-07 10:03:09Z

0

Use:

<?php
$str ='1234567891222222222233333332';

$i=0;
$char1 = $str[$i];
$isExists = array();
$found_array = array();
while(!empty($char1)) {
    if(in_array($char1, $isExists)) { 
        $i++;
        $char1 = isset($str[$i]) ? $str[$i] : '';
        continue; 
    };
    $count = 0;
    $j=0;
    $char2 = $str[$j];
    while(!empty($char2)) {
        //echo "$char1 = $char2<br>";
        if($char1==$char2) $count++;
        $j++;
        $char2 = isset($str[$j]) ? $str[$j] : '';
    }
    $isExists[] = $char1;
    $found_array[$char1] = $count;
    $i++;
    $char1 = isset($str[$i]) ? $str[$i] : '';
}

foreach($found_array as $char=>$count) {
    echo "total number of $char's = $count <br/>";  
}
?>

answered Sep 7, 2013 at 10:03

MD SHAHIDUL ISLAM

14.5k6 gold badges84 silver badges93 bronze badges

Collectives™ on Stack Overflow

How to count occurances of strings in given string wothout using a predefined string functions?

5 Answers 5

1 Comment

Output

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Output

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related