Putting Variable in Jquery Selector

Question

I just want to dynamically put in the index, which is calculating correctly, so I know the value of my variable isn't a problem, but it's not working:

My variable 'parentIndex' stores the index of the span I want to be selecting below. I have tested this variable and it returns the correct value.

$(".DropDownMenu span:eq("+parentIndex+")")

is this not the right way to put a variable into a jquery selector? all the examples i've found use this format, what am i missing?

(The entire function, for context:)

        $("span input:radio").click(function() {
        if (($(this).is(":checked")) == true) {
            var elem = $(this);
            var parent = $(this).parent();
            var aunts = parent.parent().children();
            var parentIndex = aunts.index(parent);
            var position = elem.position();
            var topValue = position.top;
            topValue = topValue - 9;
            $(".DropDownMenu").css({ "top": "-" + topValue + "px" });
            $(".DropDownMenu span").css("background-image", "none");
            parent.css({ "background": "#f3f1e7 url(assets/images/branding/DropDownArrow.gif) no-repeat right" });
            $(".DropDownMenu span:eq("+parentIndex+")").css({ "background": "#f3f1e7 url(assets/images/branding/DropDownArrow.gif) no-repeat right" });

        }
    });

JP Silvashy · Accepted Answer · 2009-12-18 19:56:47Z

1

Try this way:

$(".DropDownMenu span").eq(parentIndex)

You can find more details of this in the docs here.

However, yours should work the way it is, make sure you use FireBug to test this, and maybe try it with a less complex function just to test it's functionality.

It would be cool if JS had something like sprintf and you could do something like: $(".DropDownMenu span:eq(%parentIndex)"

But that is just wishful thinking.

edited Dec 18, 2009 at 19:56

answered Dec 18, 2009 at 19:51

JP Silvashy

48.7k50 gold badges154 silver badges230 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sarah Jean Over a year ago

it worked, it's not behaving the way i want, but that's my fault, my function is wrong

Jim Schubert · Accepted Answer · 2009-12-18 20:02:37Z

0

Have you debugged and seen what type parentIndex is?

try doing this:

$('.DropDownMenu span:eq('+ parseInt(parentIndex) +')');

answered Dec 18, 2009 at 20:02

Jim Schubert

20.4k5 gold badges64 silver badges69 bronze badges

1 Comment

Sarah Jean Over a year ago

yeah i did; it actually was working all along, I forgot i needed to use the index to figure out nth child. I was just being stupid. :-/

Collectives™ on Stack Overflow

Putting Variable in Jquery Selector

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related