Using CSS and PHP Together

Question

I have built a Wordpress plugin that requires to me to add CSS styles through the plugin's PHP file.

Is there a better way of doing this? I can see this getting out of hand if not done properly.

function flags() {  

 <style type="text/css">

  <?php if(get_option('display')=='Vertical') { ?>
    <?php if (get_option('language_option')=='specific') { ?>
        #flags {display:none !important; }
    <?php } ?>
        p.hello { font-size:12px; color:darkgray; }
  <?php } ?>

 </style>     
<?php } 
}

I would move the conditions on the html instead of the CSS. Like having a high level div class="vertical-or-not somewhere. — Kraz
– Kraz, Commented Oct 18, 2013 at 18:47
@Sven why should there be an echo? everything outside the <?php ?> is as if you would echo it at that place. That's why many libs leave out the last ?> in the document and why php documents in utf-8 with BOM cause problems. — t.niese
– t.niese, Commented Oct 18, 2013 at 18:49

nice ass · Accepted Answer · 2013-10-18 18:46:18Z

1

If there isn't much CSS, a better way is to add body classes that allow you to target your selectors only when they are present:

<body class="display-vertical">    
  ...

And move the CSS from inline to the stylesheet:

.display-vertical #flags{
   ...
}

answered Oct 18, 2013 at 18:46

nice ass

16.8k8 gold badges54 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Rob Myrick Over a year ago

Just as I thought - simplicity always wins. Thanks for the answer.

Collectives™ on Stack Overflow

Using CSS and PHP Together

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related