PHP error at file upload

Question

I am using first and sample coding for file upload. after enter the data, show the error. like

Connected successfullyUpload: bottom.png Type: image/png Size: 5.7373046875 kB Stored in: C:\xampp\tmp\phpD383.tmp Notice: Undefined index: file in C:\xampp\htdocs\Deen_php\sample.php on line 53 Could not enter data: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1

php

<?php
if(isset($_POST['insert']))
{
$dbhost = 'localhost:3306';
$dbuser = 'root';
$dbpass = 'root';
$conn = mysql_connect($dbhost, $dbuser, $dbpass);
if(! $conn )
{
  die('Could not connect: ' . mysql_error());
}
echo 'Connected successfully';


$allowedExts = array("gif", "jpeg", "jpg", "png","txt");
$temp = explode(".", $_FILES["file"]["name"]);
$extension = end($temp);

if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/jpg")
|| ($_FILES["file"]["type"] == "image/pjpeg")
|| ($_FILES["file"]["type"] == "image/x-png")
|| ($_FILES["file"]["type"] == "image/png")
|| ($_FILES["file"]["type"] == "image/txt"))
&& ($_FILES["file"]["size"] < 50000)
&& in_array($extension, $allowedExts))
  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Error: " . $_FILES["file"]["error"] . "<br>";
    }
  else
    {
    echo "Upload: " . $_FILES["file"]["name"] . "<br>";
    echo "Type: " . $_FILES["file"]["type"] . "<br>";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " kB<br>";
    echo "Stored in: " . $_FILES["file"]["tmp_name"];
    }
  }
else
  {
  echo "Invalid file";
  }

$num = $_POST['num'];
$name = $_POST['name'];
$age = $_POST['age'];
$file = $_POST['file'];



$sql = "INSERT INTO sample ".
       "(num,name,age,file1) ".
       "VALUES('$num','$name',$age, $file)";

mysql_select_db('test_db');

$retval = mysql_query( $sql, $conn );
if(! $retval )
{
  die('Could not enter data: ' . mysql_error());
}

echo "Entered data successfully\n";
move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], "C:/" . $_FILES["fileToUpload"]["name"]);

mysql_close($conn);

}
?>

html

<form action="<?php $_PHP_SELF ?>" method="POST" enctype="multipart/form-data">
  Num: <input type="text" name="num" />
  Name: <input type="text" name="name" />
  Age: <input type="text" name="age" />
  File Upload<input name="file" type="file" /><br />
  <input type="submit" id="insert" name="insert" value="Submit" />
</form>

Nouphal.M · Accepted Answer · 2014-02-06 08:42:17Z

2

You cannot access an input of type file via $_POST, it is accessed via $_FILES as in your code.

If you want to store the filename you can do

$file = $_FILES["file"]["tmp_name"];

Also if you are passing a string to db then enclose them in quotes like you have done in your query for $name and $num.

NB: Please keep in mind that mysql_* functions are deprecated. So try to use mysqli or PDO

answered Feb 6, 2014 at 8:42

Nouphal.M

6,3281 gold badge20 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user3106988 · Accepted Answer · 2014-02-06 08:43:15Z

0

I think the problem is your sql syntax. change to this:

$sql = "INSERT INTO sample (num,name,age,file1) VALUES('$num','$name', '$age', '$file')";

answered Feb 6, 2014 at 8:43

user3106988

1011 silver badge8 bronze badges

2 Comments

Mohaideen Over a year ago

Thanks. I have solved that pblm. but i have another one. File name stored in database with different. And i want to store the file into my local folder as it is same type like txt, jpg,etc move_uploaded_file($_FILES["file"]["tmp_name"], "C:/anonymous".$_FILES["file"]["name"]); is it correct

user3106988 Over a year ago

C:/anonymous/".$_FILES["file"]["name"]);

George Sovetov · Accepted Answer · 2014-02-06 08:56:40Z

0

What do you want at all?

If you want to store file contents, you should use file_get_contents instead of move_uploaded_file. To get temporary name use $_FILES["file"]["tmp_name"]. Read directly from this file.

If you want to store save file permanently and save path to this file, use move_uploaded_file with our own name (not necessary $_FILES["file"]["name"]) and save path (or meaningful part of path) that you passed to move_uploaded_file. $_POST['file'] is not set anyway.

You forgot quotes in your MySQL query.

Also, you wrote $_FILES["fileToUpload"]["tmp_name"] (other array key).

For content types (MIME) use array too.

File extension you should get using $ext = pathinfo($filename, PATHINFO_EXTENSION);.

Only correct and not deprecated way to work with MySQL is PDO with prepared statements. Your code allows SQL injections. Moreover, it's recommended to you framework afterwards.

answered Feb 6, 2014 at 8:56

George Sovetov

5,3286 gold badges43 silver badges59 bronze badges

2 Comments

Mohaideen Over a year ago

File name is stored in database successfuly. but that file didn't store in local. I want to store file local folder. I have given like this and i have created files folder in my project. but it doesn't work... move_uploaded_file($_FILES["file"]["name"], "files/".$_FILES["file"]["name"]);

George Sovetov Over a year ago

@Mohaideen You upload file from temporary location stored by tmp_name key to any custom location and name you want. $_FILES["file"]["name"] is just name that file has on the client machine and it is given just as additional information. Also, check that directory you are going to save your file exists and is accessible by PHP. First, try to save you file next to your script (__DIR__.DIRECTORY_SEPARATOR.$_FILES["file"]["name"]`). You also should to turn on full error reporting.

Mitul Shah · Accepted Answer · 2014-02-06 09:04:03Z

0

change fileToUpload to file

from

move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], "C:/" . $_FILES["fileToUpload"]["name"]);

To

move_uploaded_file($_FILES["file"]["tmp_name"], "C:/" . $_FILES["file"]["name"]);

===========================================

change sql format too.

   $sql = "INSERT INTO sample (num,name,age,file1) VALUES('$num','$name', '$age', '$file')";

============================================================

Also change file name

$file = $_POST['file'];

to

$file = $_FILES["file"]["name"]

=================================================================

change storage path too by creating upload directory in your project folder.

move_uploaded_file($_FILES["file"]["tmp_name"], "upload/" . $_FILES["file"]["name"]);

edited Feb 6, 2014 at 9:04

answered Feb 6, 2014 at 8:47

Mitul Shah

1,5661 gold badge13 silver badges36 bronze badges

3 Comments

Mohaideen Over a year ago

Thanks. I have solved that pblm. but i have another one. File name stored in database with different. And i want to store the file into my local folder as it is same type like txt, jpg,etc move_uploaded_file($_FILES["file"]["tmp_name"], "C:/anonymous".$_FILES["file"]["name"]); is it correct

Mitul Shah Over a year ago

i think it is not good to store directly on C drive. Create one folder in your project directory and story image there. move_uploaded_file($_FILES["file"]["tmp_name"], "upload/" . $_FILES["file"]["name"]); and change $file = $file = $_POST['file']; to $_FILES["file"]["name"]

Mohaideen Over a year ago

File name is stored in database successfuly. but that file didn't store in local. I want to store file local folder. I have given like this and i have created files folder in my project. but it doesn't work... move_uploaded_file($_FILES["file"]["name"], "files/".$_FILES["file"]["name"]);

Collectives™ on Stack Overflow

PHP error at file upload

4 Answers 4

Comments

2 Comments

2 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related