Error with php code (file upload)

Question

I am getting the following errors:

Notice: Undefined index: theimage in C:\wamp\www_upload\index.php on line 5

Notice: Undefined index: theimage in C:\wamp\www_upload\index.php on line 7

Here is the code:

<?php

$target_path = "images/";

$target_path = $target_path . basename( $_FILES['theimage']['name']);

if(move_uploaded_file($_FILES['theimage']['tmp_name'], $target_path)) {
echo "<p>The image ".  basename( $_FILES['theimage']['name']). " has been uploaded</p>";
} else{
echo "<p>There was an error uploading the image, please try again!</p>";
}  

?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<head>
<title></title>
<meta name="" content="">
</head>
<body>

<form enctype="multipart/form-data" action="index.php" method="POST">
<fieldset>
<input name="theimage" type="file" />
<input type="submit" value="Upload" />
</fieldset>
</form>



</body>
</html>

Any ideas on how to fix this please ?

Can you post the var_dump or print_r of the $_FILES array? Also, what are the values for these three php settings? file_uploads, upload_max_filesize, max_file_uploads — Jeff
– Jeff, Commented Aug 16, 2011 at 20:36

bfavaretto · Accepted Answer · 2011-08-16 20:37:28Z

2

<?php
if(!empty($_FILES['theimage'])) {
    // YOUR CURRENT PHP CODE HERE
?>

The problem is the upload script is executing even if nothing is posted (like when you first load the page).

answered Aug 16, 2011 at 20:37

bfavaretto

72k18 gold badges118 silver badges162 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mopsled · Accepted Answer · 2011-08-16 20:44:30Z

2

Check to make sure you're getting data in $_FILES or $_POST before you try to do anything with them:

<?php
    if(isset($_FILES)) {        // if(isset($_POST)) 
                                // would work as well
        $target_path = "images/";
        $target_path = $target_path . basename( $_FILES['theimage']['name']);
        if(move_uploaded_file($_FILES['theimage']['tmp_name'], $target_path)) {
            echo "<p>The image ".  basename( $_FILES['theimage']['name']). 
                " has been uploaded</p>";
        } else {
            echo "<p>There was an error uploading the image!</p>";
        } 
    } 
?>

edited Aug 16, 2011 at 20:44

answered Aug 16, 2011 at 20:37

mopsled

8,5451 gold badge40 silver badges41 bronze badges

Comments

Jeff Lambert · Accepted Answer · 2011-08-16 20:37:19Z

0

Change your submit button to:

<input type = 'submit' name = 'theSubmitBtn' value = 'Upload'>

Then, wrap all of your php code at the top inside of this if check:

if(isset($_POST['theSubmitBtn'])) {

... Your Code ...

}

See if that works for you. On a side note, you will also need to add much more error checking if this is to be used in a production environment.

answered Aug 16, 2011 at 20:37

Jeff Lambert

24.7k4 gold badges72 silver badges98 bronze badges

Collectives™ on Stack Overflow

Error with php code (file upload)

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related