Multiple statements in a loop with if else

Question

EDIT: Updated code to better reflect my problem

this code returns 9 strings to badDestination1

NSMutableArray* goodDestination1 = [NSMutableArray array];
NSMutableArray* badDestination1 = [NSMutableArray array];
NSMutableArray* badDestination2 = [NSMutableArray array];

for (NSString* item in sourceArray)
{
    if ([item rangeOfString:@"<b>"].location != NSNotFound)

        [goodDestination1 addObject:item];

    else {
        [badDestination1 addObject:item];
        //[badDestination2 addObject:@"Title"];
    }
}

This code returns 1 value to badDestination2

for (NSString* item in sourceArray)
    {
        if ([item rangeOfString:@"<b>"].location != NSNotFound)

            [goodDestination1 addObject:item];

        else {
            //[badDestination1 addObject:item];
            [badDestination2 addObject:@"String"];
        }
    }

anyone know whats going on? Seems like the "String" might be getting rewritten in the same location on the array maybe?

How many items are there in stringSource? If the count is 1 then it will surely only be called once. — kennytm
– kennytm, Commented Feb 9, 2010 at 15:56
I am positive there are at least 9 items being put into arrayDestinationBad1 — S-T-R-E-G-A
– S-T-R-E-G-A, Commented Feb 9, 2010 at 16:07

Michael Myers · Accepted Answer · 2010-02-09 15:50:29Z

5

Looks like you're missing the braces {} after the else.

else {
  [arrayDestinationBad1 addObject:item]; 
  [arrayDestinationBad2 addObject:@"String"]; 
}

answered Feb 9, 2010 at 15:50

Michael Myers♦

193k47 gold badges301 silver badges297 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Matthew Flaschen Over a year ago

He says it only gets called once (obviously implying he wants it called more often). Without the braces it /should/ get called every time through the loop.

Michael Myers Over a year ago

@Matthew: That's true, but what else could be the problem with that code?

Matthew Flaschen Over a year ago

I don't know, but adding the braces can only make it run less (<=) often. :)

Michael Myers Over a year ago

Perhaps it was mis-copied and that statement is actually outside the loop. That's the only thing I can think of.

Michael Myers Over a year ago

So it was a dictionary and not an array? Tsk, tsk. ;)

|

Collectives™ on Stack Overflow

Multiple statements in a loop with if else

1 Answer 1

10 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

10 Comments

Your Answer

Sign up or log in

Post as a guest

Related