For loop for multiple condition over Multiple conditions in single if statement

Question

I had seen a code like this

if ([[dict objectForKey:@"name"] rangeOfString:@“AB”].location != NSNotFound ||
    [[dict objectForKey:@"name"] rangeOfString:@“CD”].location != NSNotFound ||
    [[dict objectForKey:@"name"] rangeOfString:@“EF”].location != NSNotFound ||
    [[dict objectForKey:@"name"] rangeOfString:@“GH”].location != NSNotFound ||
    [[dict objectForKey:@"name"] rangeOfString:@“IJ”].location != NSNotFound ||){
    // do something
   }

Which I changed to:

NSArray *myArray = [NSArray arrayWithObjects:@“AB”,
                @"CD", @"EF", @"GH", @"IJ", nil];

for (id object in myArray) {
    if ([[dict objectForKey:@"name”] rangeOfString: id].location != NSNotFound){
        // do something
        break;
    }
}

I understand readability is better after changing the code. Does it have any other advantages?

nothing that im aware of, but just being anal here, you should make your for loop like for(String <#stringName#> in myArray) rather, and if you want you can change [dict objectForKey:@"name”] to just dict[@"name"] but thats debatable whether thats more readable (less explicit, but less clutter which i prefer) — Fonix
– Fonix, Commented Jan 12, 2015 at 5:23
I agree the code is written in Objective-c but I felt the use-case is applicable for c also. Will remove the tag. — Vishvesh
– Vishvesh, Commented Jan 12, 2015 at 5:34

danh · Accepted Answer · 2015-01-12 05:34:05Z

2

I don't see any substantial difference. You could further improve readability and terseness by pulling the dictionary access out of the loop.

// probably done for you by the compiler, but still prettier to look at...
NSString *name = dict[@"name"];

for (id object in myArray) {
    if ([name rangeOfString:id].location != NSNotFound){
        // do something
        break;
    }
}

answered Jan 12, 2015 at 5:34

danh

62.7k10 gold badges100 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nikolai Ruhe Over a year ago

Agree. Minor note: The compiler can't do the optimization as the dict lookup is invisible to it and may have side effects.

Collectives™ on Stack Overflow

For loop for multiple condition over Multiple conditions in single if statement

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related