I would like to write something like this but I am not sure how.
for(int i = 0; i < ( the greater value between intA and intB ); i++)
5 Answers
The expression in the middle of your for statement works exactly like any if statement; the loop only continues when the expression evaluates as true. So there are a few logically equivalent ways to write what you want:
// using a ternary operator
for (int i=0; i < ((intA > intB) ? intA : intB); ++i)
{
// do stuff
}
// using a simple Boolean OR
for (int i=0; i < intA || i < intB; ++i)
{
// do stuff
}
// using a MAX macro
for (int i=0; i < MAX(intA, intB); ++i)
{
// do stuff
}
But in your specific case, none of these are ideal since the first two aren't really clear code and they all evaluate intA vs intB on each iteration through the loop. What's even better is something like:
int maxAB = MAX(intA, intB);
for (int i=0; i < maxAB; ++i)
{
// do stuff
}
1 Comment
Sam
+1 good answer. The key point is that the for loop conditional is evaluated on each iteration, so when possible avoid unnecessary evaluations like adpalumbo did with his
maxAB variable in the last code block example.Use the ternary operator:
for(int i = 0; i < (intA > intB ? intA : intB); i++)
Comments
Use tha MAX macro.
MAX( a, b )
If it's not available, you can define it:
#define MAX( a, b ) ( ( ( a ) > ( b ) ) ? ( a ) : ( b ) )
4 Comments
N_A
Are all those parenthesis needed?
N_A
huh? I said parenthesis, not parameters.
Macmade
Ooops... sorry : P The parenthesis are needed in case you are dealing with complex expressions, instead of variables.
N_A
Ooooh... assignment operators and the comma operator have lower precedence than the ternary operator. Eck.
I would suggest using the MAX macro or using an extra if statement before each execution of the for statement. Using the ternary operator is not clear enough to support future mainteinance. But that's just my opinion.
ifoutside theforexpression makes me think he wants to test the resulting values or something.fornotifat the start there.