JavaScript regex for email fails. Why? [duplicate]

Question

This is a ready-baked regex that I got from the internet just to see how regex works in JavaScript (and jQuery). Here is my script:

<script>
    $(document).ready(function(){
        var regexp = new RegExp(([\w-\.]+)@((?:[\w]+\.)+)([a-zA-Z]{2,4}));
        $("#submit").click(function(){
            var result = regexp.test( $("#email").val() );
            if(result){
                $("form").submit();
            }else{
                alert("Invalid Email Address");
            }
        });
    });
</script>

However, the form always submits despite entering a wrong email address.

I have read on how test() works. It know that it returns the right answer and then advances a pointer to the next value. So if it returns true, the pointer points to false. I do not see how that can be a problem here.

what is wrong here? :)

HTML:

<body>
    <center>
        <form name="subscription" method="post" action="http://www.cs.tut.fi/cgi-bin/run/~jkorpela/echo.cgi">
            <input type="text" name="email" size="30" id="email"></input>
            <button id="submit">Submit</button>
        </form>
    </center>
</body>

@PratikJoshi With all due respect, I feel you are being a little disrespectful here. — An SO User
– An SO User, Commented Mar 31, 2014 at 6:45
Please check console errors first-> Uncaught SyntaxError: Unexpected token ILLEGAL — Pratik Joshi
– Pratik Joshi, Commented Mar 31, 2014 at 6:47
@LittleChild , With all respect , Why do you feel so ?I mean if you expect good answer ,then you should not assume ,that we know your html, So please post jsfiddle ,and include HTML. — Pratik Joshi
– Pratik Joshi, Commented Mar 31, 2014 at 6:56

Sahil Mittal · Accepted Answer · 2014-03-31 06:57:56Z

2

You need to double escape your Regex. Try this-

var regexp = new RegExp("([\\w-\\.]+)@((?:[\\w]+\\.)+)([a-zA-Z]{2,4})");

Edit

It is always helpful to log the result so that you see if your regexp string is correct, eg:

console.log("([\\w-\\.]+)@((?:[\\w]+\\.)+)([a-zA-Z]{2,4})");
console.log("([\w-\.]+)@((?:[\w]+\.)+)([a-zA-Z]{2,4})");

edited Mar 31, 2014 at 6:57

answered Mar 31, 2014 at 6:49

Sahil Mittal

20.7k12 gold badges68 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

An SO User Over a year ago

Done !! Working !! :-)

An SO User Over a year ago

Few more minutes to go :)

MrProgram · Accepted Answer · 2014-03-31 06:46:32Z

2

Use this instead?

<input type="email" />

answered Mar 31, 2014 at 6:46

MrProgram

5,26213 gold badges61 silver badges101 bronze badges

1 Comment

An SO User Over a year ago

Yes, that is an option but the idea is to see how regex work. That's all :)

Amit Joki · Accepted Answer · 2014-03-31 07:05:05Z

2

Your regex initialization should be string and it should be escaped.

var regexp = new RegExp("([\\w\\.-]+)@((?:[\\w]+\\.)+)([a-zA-Z]{2,4})");

You can also use:

var regexp = /([\w\.-]+)@((?:[\w]+\.)+)([a-zA-Z]{2,4})/;

edited Mar 31, 2014 at 7:05

answered Mar 31, 2014 at 6:45

Amit Joki

59.4k7 gold badges80 silver badges96 bronze badges

5 Comments

An SO User Over a year ago

ah ! I didnt see the tutorial mention that :)

An SO User Over a year ago

uhm... still doesnt solve the problem.

Amit Joki Over a year ago

what do you mean by not solving the problem?

Pratik Joshi Over a year ago

still it shows console error

An SO User Over a year ago

@AmitJoki : Range out of order in character class

VeXii · Accepted Answer · 2014-03-31 06:49:33Z

0

write it a regex (note the /)

Regex: var regexp = new RegExp(/([\w-\.]+)@((?:[\w]+\.)+)([a-zA-Z]{2,4})/);

answered Mar 31, 2014 at 6:49

VeXii

3,1091 gold badge21 silver badges25 bronze badges

Comments

TELMILA · Accepted Answer · 2014-03-31 06:51:39Z

0

In Html5, There is a new attribute type="email" is available.

Instead of using input type="text"

Please try this!

answered Mar 31, 2014 at 6:51

TELMILA

839 bronze badges

Comments

TELMILA · Accepted Answer · 2014-03-31 08:20:11Z

0

Please try like this:

var regex = /^[a-zA-Z0-9äöüÄÖÜ._-]+@[a-zA-Z0-9äöüÄÖÜ.-]+.[a-zA-Z]{2,4}$/;

answered Mar 31, 2014 at 8:20

TELMILA

839 bronze badges

Collectives™ on Stack Overflow

JavaScript regex for email fails. Why? [duplicate]

6 Answers 6

2 Comments

1 Comment

5 Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

1 Comment

5 Comments

Comments

Comments

Comments

Linked

Related