Add string at the end of every loop but not for the last loop [duplicate]

Question

I am creating a function to set query vars as below.

function set_query_var(array $params)
{
    $count = count($params);
    $query_var = '?';        

    foreach ( $params as $key => $value)
    {
        $query_var .= $key . '=' . $value .
        (($count > 1) ? '&' : NULL);
    }

    return $query_var;
}

Above function works fine but only issue is that, it is adding & to the end loop which I don't want.

How can I fix it?

Looks like you're reinventing the wheel: http_build_query() — Alma Do
– Alma Do, Commented Aug 12, 2014 at 7:05
@AlmaDo +1 and thanks a lot. I didn't know this function. It might be useful here to me.. Thanks again. — Code Lover
– Code Lover, Commented Aug 12, 2014 at 7:10

Community · Accepted Answer · 2023-11-14 22:25:35Z

7

I always use implode and array:

function set_query_var(array $params)
{
    $query_var = [];        

    foreach ($params as $key => $value) {
        $query_var[] = "{$key}={$value}";
    }

    return '?' . implode('&', $query_var);
}

edited Nov 14, 2023 at 22:25

CommunityBot

11 silver badge

answered Aug 12, 2014 at 7:06

Justinas

43.9k5 gold badges72 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Code Lover Over a year ago

Wonderful and optimized solution. Thanks a lot.... BTW Alma Do also gave me nice suggestion to use built in function.

Justinas Over a year ago

@CodeLover yes, but my way is used more widely, not just for URL. I usually use it for SQL WHERE statements.

Mad Angle · Accepted Answer · 2014-08-12 07:06:43Z

0

function set_query_var(array $params)
{
    $count = count($params);
    $query_var = '?';        

    foreach ( $params as $key => $value)
    {
        $query_var .= $key . '=' . $value .
        (($count > 1) ? '&' : NULL);
    }
    $query_var = rtrim( $query_var, "&");
    return $query_var;
}

answered Aug 12, 2014 at 7:06

Mad Angle

2,3301 gold badge18 silver badges33 bronze badges

Comments

Athafoud · Accepted Answer · 2014-08-12 07:21:03Z

0

An easy and dirty solution to you problem is to remove the last & from your string.

rtrim($string, "&");

would cut trailing &.

edited Aug 12, 2014 at 7:21

answered Aug 12, 2014 at 7:04

Athafoud

3,0603 gold badges45 silver badges61 bronze badges

Collectives™ on Stack Overflow

Add string at the end of every loop but not for the last loop [duplicate]

3 Answers 3

2 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Linked

Related