Multiple parameters in macro

Question

I am trying to simplify writing my embedded programs in C. How would I create a macro that could accept any number or parameters up from 2?

I currently have this:

#define P_PIN_HIGH(pin_letter, pin_num)         (PORT##pin_letter |= (1 << pin_num))
#define PIN_HIGH(...)           P_PIN_HIGH(__VA_ARGS__)

And I can use this like so:

#define PIN_TEST    A, 0    // Every pin gets defined this way.

PIN_HIGH(PIN_TEST);         // Set this pin to high.

But, I would like to be able to pass any number of pins(they must have the same letter) to the macro, like so:

#define PIN_TEST     A, 0
#define PIN_TEST1    A, 1
#define PIN_TEST2    A, 2

PIN_HIGH(PIN_TEST, PIN_TEST1, PIN_TEST2);

So, the compiled code, would look like this:

PORTA |= ((1<<0) | (1<<1) | (1<<2));

Is this doable?

Do you mean "number of paramaters" >= 2? In this case it's possible. The syntax is: #define MACRO(A, B, ...) and then inside the macro the part corresponding to ... is obtained, again, with __VA_ARGS__. — user2698605
– user2698605, Commented Sep 5, 2014 at 16:26
possible duplicate of Variable arguements in macro using ellipsis — Fred Larson
– Fred Larson, Commented Sep 5, 2014 at 16:29
No, not a duplicate. By bigger >= 2, I just meant that at least one pin has to be passed to macro. — user1806687
– user1806687, Commented Sep 5, 2014 at 16:31

programmerjake · Accepted Answer · 2014-09-05 17:07:03Z

1

not really. If you can use c++ then it's very easy with templates.

template <volatile char *port_, size_t bit_number_>
struct port_descriptor
{
    static constexpr size_t bit_number = bit_number_;
    static volatile char *const port;
};
template <volatile char *port_, size_t bit_number_>
volatile char *const port_descriptor<port_, bit_number_>::port = port_;

typedef port_descriptor<&PORTA, 0> PIN_TEST;

template <class ...args>
char get_set_port_value(bool new_value);

template <class ...args>
void set_port_value(bool new_value);

template <volatile char *port_, size_t bit_number_>
char get_set_port_value<port_descriptor<port_, bit_number_>>(bool new_value)
{
    char v = *port_;
    if(new_value)
        return v | 1 << bit_number_;
    return v & ~(1 << bit_number_);
}

template <volatile char *port_, size_t bit_number_, class ...Args>
char get_set_port_value<port_descriptor<port_, bit_number_>, Args...>(bool new_value)
{
    char v = get_set_port_value<Args...>();
    if(new_value)
        return v | 1 << bit_number_;
    return v & ~(1 << bit_number_);
}

template <volatile char *port_, size_t bit_number_, class ...Args>
void set_port_value<port_descriptor<port_, bit_number_>, Args...>(bool new_value)
{
    char v = get_set_port_value<port_descriptor<port_, bit_number_>, Args...>(new_value);
    *port_ = v;
}

then you can do set_port_value<PIN_TEST>(true);

answered Sep 5, 2014 at 17:07

programmerjake

1,82412 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

user1806687 Over a year ago

No, its a program for a microcontroller.

programmerjake Over a year ago

which microcontroller?

user1806687 Over a year ago

8-bit AVR, it would be an overkill to use C++.

programmerjake Over a year ago

I have always used avr-g++ and arduino is actually C++.

user1806687 Over a year ago

I am not using arduino. I am programming "raw AVR".

|

shikamaru · Accepted Answer · 2014-09-05 16:51:43Z

0

Your P_PIN_HIGH() macro seems to take only two arguments. In your variadic macro PIN_HIGH, you are passing 3 argument pairs which, as per that macro's definition, would be passed as arguments to P_PIN_HIGH (which expects only 2 arguments). Seems like you would want to iterate over your argument pairs, in your P_PIN_HIGH() macro, by explicitly passing the number of argument pairs.

answered Sep 5, 2014 at 16:51

shikamaru

544 bronze badges

1 Comment

user1806687 Over a year ago

Yes, that's right, I would want to iterate. How would I accomplish that?

Collectives™ on Stack Overflow

Multiple parameters in macro

2 Answers 2

6 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related