Check and Uncheck Checkbox

Question

Why when I check the checkbox it works fine when I uncheck it nothing happen

Checked Unchecked

<form method="get">
    <table id="row">
        <tr><th colspan="2" >Location</th></tr>
        <tr><td>Country:</td><td><select id="country" name ="country"  style="width:200px"></select></td></tr>
        <tr><td>City:</td><td><select name ="city" id ="state"></select></td></tr>
        <script language="javascript">
            populateCountries("country", "state");
        </script>
        <tr><td></td><td><input onclick="myFunction()" type="checkbox" name="manualentry" value="manualentry" >Manual Entry</td></tr>
        <script>
            var table = document.getElementById("row");
            function  myFunction() {
                if (document.getElementsByTagName('manualentry').checked = true) {
                    document.getElementById("row").deleteRow(2);
                    var row = table.insertRow(2);
                    var cell1 = row.insertCell(0);
                    var cell2 = row.insertCell(-1);
                    cell1.innerHTML = "City:";
                    cell2.innerHTML = '<input  type="text" >';
                } else {
                    document.getElementById("row").deleteRow(2);
                    var row = table.insertRow(2);
                    var cell1 = row.insertCell(0);
                    var cell2 = row.insertCell(1);
                    cell1.innerHTML = "City:";
                    cell2.innerHTML = '<select name ="city" id ="state"></select>';
                }
            }
        </script>
        <tr ><td  colspan="2" align="right" > <input type="submit" value="Submit"></td></tr>
    </table>
</form>

JD Davis · Accepted Answer · 2015-11-24 23:03:28Z

1

A couple things. GetElementsByTagName is the wrong function call, that method is used to get an array of elements by their actual HTML tag. Use GetElementsByName instead. Also, this call will return an array, so you need to specify which index it is (it will be index 0). Since checked is already a boolean value, you do not need to specify == true.

Replace if (document.getElementsByTagName('manualentry').checked = true)

with if (document.getElementsByName('manualentry')[0].checked)

answered Nov 24, 2015 at 23:03

JD Davis

3,7705 gold badges32 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tobias Schäfer · Accepted Answer · 2015-11-24 23:00:28Z

0

You forgot a = in the if condition:

if (document.getElementsByTagName('manualentry').checked = true) {

try

if (document.getElementsByTagName('manualentry').checked == true) {

answered Nov 24, 2015 at 23:00

Tobias Schäfer

1,3683 gold badges17 silver badges39 bronze badges

1 Comment

Fernando Ramos Over a year ago

With == nothing happen

Collectives™ on Stack Overflow

Check and Uncheck Checkbox

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related