Laravel eloquent model how to get data from relationship's table

Question

I am developing a laravel application which has the following eloquent models

Product hasMany('App/Sku','products_id')
Sku belongTO('App/Product')

I have a controller 'ProductController' where the following code is available

public function index()
{    
    $products = Product::all();
    foreach($products as $product){
            $products_id = $product->products_id;
    }
}

I am exposing RESTfull API which will allow my users to get all product details (including skus, shipping types etc..).

Suppose if I have an API GET : /products

The code which fetches all the product details will be some what the following

public function index()
{              
      $products = Product::all();
      foreach($products as $product){
          $products_id = $product->products_id;
          $skus_data = Product::find($products_id)->skus;
      }
        // Now I have both the product details + skus which I can bundle into an array/json.
}

Now my question is , is this logic proper? In this case all the logics are in the controller since im using eloquent models I have a model for each table and the relationships are defined in it. Is there a way I can get all the details of a product/associated model (Products details (in table 1)+ Sku details (in table 2)) rather than using the below

foreach($products as $product){
    $products_id = $product->products_id;
    $skus_data = Product::find($products_id)->skus;
}

I am pretty new to laravel development and eloquent models. I will be using repository pattern for the development and in that case where does the aboe logic (Product+Sku combining) resides.

Please help out.

Moppo · Accepted Answer · 2017-03-07 07:50:50Z

50

Yes, you can get the details of the products and skus without making one additional query per product using eager loading ( this is referred as the typical N+1 query problem where N is the number of the products )

Suppose the relation between your Product and Sku models model is:

Product

public function skus()
{
    return hasMany('App/Sku','products_id');
}

To fetch the products data along with the sku data you can use the with method. In your controller:

Controller

 $products = Product::with('skus')->get();

Then, in your views, you can get the info this way:

View

foreach ($products as $product) 
{
     //$product->skus is a collection of Sku models
     dd( $product->skus );
}

For the repository question: if you want to use a repository you can place the eloquent-access part of your code inside the repository. So, for example you could have this method inside the repository:

ProductRepository

public function getProductsData() 
{
    //access eloquent from the repository
    return Product::with('skus')->get();    
}

then you can use your repository in your controller:

Controller

//inject the repository in the controller
public function __construct( ProductRepository $productRepo )
{
    $this->productRepo = $productRepo;
}

//use the injected repository to get the data
public function index()
{
    $products = this->productRepo->getProductsData();
}

edited Mar 7, 2017 at 7:50

answered Dec 4, 2015 at 8:41

Moppo

19.4k5 gold badges68 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ajeesh Over a year ago

Thanks for the detailed answer. One more query I am having from your answer is where does all my data validations happen? Is it in the controller or repository and can I treat a repository as a library like in codeigniter?

Moppo Over a year ago

@user34305 : To validate the data you can do it in different way: in your controller, in your models, or using specific classes, it depends on your needs and preferences: check here to get more info. For the codeigniter part i can't help as i don't use it :)

kalehmann · Accepted Answer · 2019-04-09 09:23:29Z

2

If the repository pattern is used, do it like this.

public function index() {
    $data = $this->passportRepository->with('user')->findWhere(['id'=>1]);
}

edited Apr 9, 2019 at 9:23

kalehmann

5,0896 gold badges29 silver badges37 bronze badges

answered Jan 17, 2018 at 10:47

Kaushik shrimali

1,23811 silver badges16 bronze badges

Comments

Fester · Accepted Answer · 2015-12-04 08:41:38Z

1

If I understand your question correctly, you can use eager loading.

 public function index()
 {
    $products = Product::with('skus')->get();
 }

This will give you an array of products that have a skus array in each product object.

answered Dec 4, 2015 at 8:41

Fester

8801 gold badge12 silver badges33 bronze badges

Comments

Dino · Accepted Answer · 2019-11-09 15:59:20Z

0

You can try this:

public function index()
{
    $products = Product::all();
    foreach($products->skus as $product)
    {
         return $product;
    }

}

This will give you the exact result in the object form.

edited Nov 9, 2019 at 15:59

Dino

8,37213 gold badges50 silver badges93 bronze badges

answered Nov 9, 2019 at 5:32

Vishrut_Naik

113 bronze badges

1 Comment

Eduardo Baitello Over a year ago

Code-only answers are generally frowned upon on this site. Could you please edit your answer to include some comments or explanation of your code? Explanations should answer questions like: What does it do? How does it do it? Where does it go? How does it solve OP's problem? See: How to anwser. Thanks!

Collectives™ on Stack Overflow

Laravel eloquent model how to get data from relationship's table

4 Answers 4

2 Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest