Laravel request int and string keys weird behaviour

Question

Imagine - Laravel application, a get requst is made.

The situation is, that a custom request, which has inputs with integer names, is made. In the custom request file I'm adding another field, lets say "fields". So at first the $request->all() returns

array(
     1 => "value1",
     5 => "value5",
     12 => "value12",
)

and after adding the new field $request->all() returns

array(
     1 => "value1",
     5 => "value5",
     12 => "value12",
     "fields" => array(
                      "key" => "value",
                 ),
)

Now the problem occurs - $request->get("fields") returns null.

$request->all() returns with fields.

$request->only(["fields"]) returns array with fields.

$request->exists("fields") returns true.

Why is it so?

EDIT

Adding the new field inside the custom request class:

public function getValidatorInstance()
{
    $validator = parent::getValidatorInstance();

    $validator->after(function() use ($validator, $event)
    {
         $this->merge(["fields" => ["key" => "value"]]);
    }
    return $validator;
}

I've never used $request->get() before, can you try your code with $request->input('fields') instead? — Yanaro
– Yanaro, Commented Jul 27, 2016 at 15:09
@MihkelAllorg You're probably confused with input->get(), there's no request->get(), only request->input(); — Yanaro
– Yanaro, Commented Jul 27, 2016 at 15:21

Andrew Nolan · Accepted Answer · 2016-07-27 15:32:54Z

1

$request->all() should return all data submitted through the request. Behaving as it should.

$request->only(["fields"]) is getting the fields key from the request and casting it to an array due to the []. Normal behavior

$request->exists("fields") is just checking if that key exists in the request data. Normal behavior

Looking into Illuminate\Http\Request, I do not see a get() method. I only method I have seen used to extract input from a request is $request->input('fieldName'). However there is a __get() method in Illuminate\Http\Request that seems to work. I would stick with the input() method since it is more explicit.

answered Jul 27, 2016 at 15:32

Andrew Nolan

2,1272 gold badges22 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jeff Lambert Over a year ago

Request::get is defined in Symfony\Component\HttpFoundation\Request, the parent class.

Andrew Nolan Over a year ago

Ah, didn't dig far enough down :P . Thx

Mihkel Allorg Over a year ago

Thanks for the answer @AndrewNolan, but my question was why isn't the get() method working. :)

Jeff Lambert · Accepted Answer · 2016-07-27 15:50:24Z

0

I think you may have a simple scoping issue, and $this isn't available in your validator's after closure:

$validator->after(function() use ($validator, $event, $this)
{
     $this->merge(["fields" => ["key" => "value"]]);
}

If you're using PHP 5.3 or below the above won't work, you will need to capture a reference to $this in the parent scope:

$self = $this;
$validator->after(function() use ($validator, $event, $self)
{
     $self->merge(["fields" => ["key" => "value"]]);
}

answered Jul 27, 2016 at 15:50

Jeff Lambert

24.7k4 gold badges72 silver badges98 bronze badges

1 Comment

Mihkel Allorg Over a year ago

If I had a scoping issue, ..->exists("fields") would return false, and in ...->all() it wouldn't show either. good guess tho

Collectives™ on Stack Overflow

Laravel request int and string keys weird behaviour

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related