Ember cannot read property 'find' of undefined

Question

We just installed an error-tracker for our Ember-application, and the only error that is reported is Cannot read property 'find' of undefined. The code that cause this error is within a component, and looks like this:

this.set('interval', setInterval(() => {
  const current = this.get('counter') - 1;
  this.set('counter', current);
  this.$().find('.countdown-number').text(current); // <- error here
}, 1000));

I don't understand how this can happen. How can $() be undefined, since it's a part of the ember framework?

According to the error-tracker, it happens for a bunch of different browsers, latest Chrome for example. I however can't reproduce the error in any browser.

I know this isn't the "ember way" of updating a text in a div, but I would prefer to not have to rebuild a lot, I just want to fix the bug with as little changes as possible.

Daniel · Accepted Answer · 2017-02-03 09:25:52Z

1

this.$() will be undefined if component is destroyed or didn't render properly. Make sure you call this.$() only when component is in DOM and on willDestroyElement you remove all events that could access this.$().

answered Feb 3, 2017 at 9:25

Daniel

18.7k8 gold badges69 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

TheQ Over a year ago

Ahh, that actually makes a lot of sense! Updated the code in the question above, and as you can see it's an interval that probably keeps going even after the component is destroyed. Adding clearInterval to willDestroyElement might be a solution, i'll try it out.

Daniel Over a year ago

Definitely this should fix things. You have reference stored as interval so it should be quick fix. :)

TheQ Over a year ago

It works perfectly, not a single error for 4 hours now, while we previously had several every minute. Thanks! :)

Daniel Over a year ago

Very happy to hear! :)

Collectives™ on Stack Overflow

Ember cannot read property 'find' of undefined

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related