66

I'm trying to set up some nested routes to add a common layout. Check the code out:

  <Router>
    <Route component={Layout}>
      <div>
        <Route path='/abc' component={ABC} />
        <Route path='/xyz' component={XYZ} />
      </div>
    </Route>
  </Router>

While this works perfectly fine, I still get the warning:

Warning: You should not use <Route component> and <Route children> in the same route; will be ignored

1

5 Answers 5

83

CESCO's answer renders first the component AppShell then one of the components inside Switch. But these components are NOT going to render inside AppShell, they will NOT be children of AppShell.

In v4 to wrap components you don't put anymore your Routes inside another Route, you put your Routes directly inside a component.
I.E : for the wrapper instead of <Route component={Layout}> you directly use <Layout>.

Full code :

  <Router>
    <Layout>
      <Route path='/abc' component={ABC} />
      <Route path='/xyz' component={XYZ} />
    </Layout>
  </Router>

The change is probably explained by the idea to make React Router v4 to be pure React so you only use React elements like with any other React element.

EDIT : I removed the Switch component as it's not useful here. See when it's useful here.

Sign up to request clarification or add additional context in comments.

7 Comments

Thanks! Wrapping it like: <Layout><Switch><Route/></Switch></Layout> worked for me :)
No problem. If you use a single Route you do NOT need Switch. Switch is like the || operator : the first Route inside a Switch statement that match path is rendered but the other Routes inside the Switch are NOT rendered. I added a link to the doc of Switch in my comment.
Great solution. I
Thanks, this helped me to better understand and solve the problem.
How would one get a location object or location.pathname inside of Layout component (ie. this.props.location.pathname)?
|
10

You need to use the switch component to nesting to work nice. Also, see this question

// main app
<div>
    // not setting a path prop, makes this always render
    <Route component={AppShell}/>
    <Switch>
        <Route exact path="/" component={Login}/>
        <Route path="/dashboard" component={AsyncDashboard(userAgent)}/>
        <Route component={NoMatch}/>
    </Switch>
</div>

And version-4 components do not take children, instead, you should use the render prop.

<Router>
    <Route render={(props)=>{
      return <div>Whatever</div>}>
    </Route>
  </Router>

Comments

5

Try:

<Router>
    <Layout>
        <Route path='/abc' component={ABC} />
        <Route path='/xyz' component={XYZ} />
    </Layout>
</Router>

3 Comments

When you add the answer, add some explanation so that its useful for others. However +1 for answering it first
Not a useful comment. Giving an example doesn't always help.
This seems to work with BrowserRouter instead of Router too.
2

If you do not want Layout to run at loaded. Use this method:

<div className="container">
    <Route path="/main" component={ChatList}/>
    <Switch>
        <Route exact path="/" component={Start} />
        <Route path="/main/single" component={SingleChat} />
        <Route path="/main/group" component={GroupChat} />
        <Route path="/login" component={Login} />
    </Switch>
</div>

Whenever history changes, componentWillReceiveProps in the ChatList will run.

Comments

0

You can also try this :

<Route exact path="/Home"
                 render={props=>(
                                 <div>
                                      <Layout/>
                                      <Archive/>
                                </div>
                       )} 
    />

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.