Password validation won't work Javascript

Question

Trying to get my page to take a password that is 8 or more characters length and contains a number and a letter, but its not working and I don't understand why. Once the password is valid, it takes the user to a success page.

CODE:

<script>
  $(document).ready(function() {
    $("#submit").click(function() {

      var name = document.getElementById("name").value;
      var email = document.getElementById("email").value;
      var password = document.getElementById("password").value;
      var confirm = document.getElementById("confirm").value;
      var valid = password.length >= 8 // at least 8 characters
                  && /[a-z]/.test(password) // contains a lowercase letter
                  && /\d/.test(password) // contains a digit


      var dataString = 'name=' + name + '&email=' + email + '&password=' + password;
      console.log(dataString);
      if (name == '' || email == '' || password == '') {
        alert("Fill in empty fields");
      }
      if (password != confirm) {
        alert("Passwords do not match.");
      } else if (password == confirm && password != valid) {
        alert("Password not valid.");
      } else if(password == '' && confirm == '' && password == confirm) {
        alert("password can't be empty");
      } else {
        alert("matched");
        window.location="newpage.html"
      }
      return false;
    });
  });
</script>

Please help me :(

@ste2425 The password if statements, I keep getting "password not valid", when I enter 'password1' and I can't see why. Is there a better way to check password is 8 or more characters and contains 1 number and letter? — MechroMancer
– MechroMancer, Commented Mar 20, 2017 at 15:43
You've a logic error in your statements: comparing password != valid where password is your string and valid is a boolean. Perhaps you should be checking password == confirm && !valid? — chazsolo
– chazsolo, Commented Mar 20, 2017 at 15:44
BTW, if you let me digress, just yesterday I read this article about password rules I fully agree with. — Álvaro González
– Álvaro González, Commented Mar 20, 2017 at 15:48

Murali VP · Accepted Answer · 2017-03-20 15:45:15Z

1

if(password == confirm && !valid)

should be that.

answered Mar 20, 2017 at 15:45

Murali VP

6,4674 gold badges32 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JorgeObregon · Accepted Answer · 2017-03-20 15:48:23Z

Instead of a huge function, break it into pieces (smaller functions). That way is easier to manage any error, bugs, maintenance etc.

Now, specifically answer your question on "password validation function", check this snippet.

(function($){ $(function(){
   
  var isPasswordValid = function(password){
    return password.length >= 8 
      && /[a-z]/.test(password)
      && /\d/.test(password)
  }
  
  console.log('Is "weakpwd" valid?', isPasswordValid('weakpwd'));
  
  console.log('Is "atLeastEightChars" valid?', isPasswordValid('atLeastEightChars'));
  
  console.log('Is "Gr3atPassword!" valid?', isPasswordValid('Gr3atPassword!'));
  
}) })(jQuery)

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

I used the same checks you used for the password... and it's good! Which means the problem you're having is somewhere else, not in the password-checking step.

Cheers,

Collectives™ on Stack Overflow

Password validation won't work Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related