Php doesn't create users in database

Question

I wrote a code that protects me from sql injections, but now it doesn't even create users. Here is the my code:

    <?php
$user = $_GET['username'];
$pass = $_GET['password'];

$servername = "localhost";
$username = "root";
$password = "";
$dbname = "test123";

$conn = new mysqli($servername, $username, $password, $dbname);
function selectInfo($user, $pass){
    global $conn;
    $stmt = $conn->prepare("INSERT INTO users (username, password) VALUES (?, ?)");
    $stmt->bind_param("ss", $user, $pass);
    $stmt->execute();
    $stmt->close();
    }
?>

i get no error when executing but it doesn't create users that i need. Sorry for bad code. Im new at this.

Are you passing username and pasword in url? Its also strange any one can know your password. — B. Desai
– B. Desai, Commented Jul 29, 2017 at 7:28
If you want to use $conn in your function, then pass it in as a parameter, try not to use global if you can avoid it. — Nigel Ren
– Nigel Ren, Commented Jul 29, 2017 at 7:34
I use get because i want to use it with c#, but maybe i wont use it. — deniz07
– deniz07, Commented Jul 29, 2017 at 7:35

Exprator · Accepted Answer · 2017-07-29 07:30:49Z

3

the real reason is you are not calling the function

either do this

  <?php
$user = $_GET['username'];
$pass = $_GET['password'];

$servername = "localhost";
$username = "root";
$password = "";
$dbname = "test123";

$conn = new mysqli($servername, $username, $password, $dbname);
function selectInfo($user, $pass){
    global $conn;
    $stmt = $conn->prepare("INSERT INTO users (username, password) VALUES (?, ?)");
    $stmt->bind_param("ss", $user, $pass);
    $stmt->execute();
    $stmt->close();
    }
selectInfo($user, $pass);
?>

or

<?php
$user = $_GET['username'];
$pass = $_GET['password'];

$servername = "localhost";
$username = "root";
$password = "";
$dbname = "test123";

$conn = new mysqli($servername, $username, $password, $dbname);

    $stmt = $conn->prepare("INSERT INTO users (username, password) VALUES (?, ?)");
    $stmt->bind_param("ss", $user, $pass);
    $stmt->execute();
    $stmt->close();


?>

answered Jul 29, 2017 at 7:30

Exprator

27.8k6 gold badges54 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nana Partykar Over a year ago

"..not calling the function" was the catch.

deniz07 Over a year ago

Well, i can't believe i didn't called the function. Must be so blind :D

Collectives™ on Stack Overflow

Php doesn't create users in database

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related