Variable initializer redundant

Question

I'm not entirely sure what the issue is, but here is a snippet of my code. I get the warning for my line variable

StringBuffer stringBuffer = new StringBuffer();

String line = "" ;
while(( line = bufferedReader.readLine()) != null ){
    stringBuffer.append(line);
}

Why not use newer APIs? new String(Files.readAllBytes(...), UTF-8) — Boris the Spider
– Boris the Spider, Commented Dec 15, 2018 at 16:19

ernest_k · Accepted Answer · 2018-12-15 16:22:36Z

2

The warning simply means that the empty string with which the line variable is initialized is useless.

Before line is read, it is being assigned in the loop declaration:

line = bufferedReader.readLine()

So assigning line = "" is redundant. You can leave it uninitialized:

String line;
while((line = bufferedReader.readLine()) != null) {
    stringBuffer.append(line);
}

edited Dec 15, 2018 at 16:22

answered Dec 15, 2018 at 16:14

ernest_k

45.5k5 gold badges58 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

logbasex · Accepted Answer · 2019-12-12 08:19:21Z

1

Append to @ernest_k answer, assigning line = "" is redundant only if you reassign line with another value and you don't use line in return statement or set statement (set value need at least null value).

answered Dec 12, 2019 at 8:19

logbasex

2,4781 gold badge24 silver badges29 bronze badges

Collectives™ on Stack Overflow

Variable initializer redundant

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related