Strcmp pointer from integer without cast

Question

I'm trying to compare two character and see which one is lexicographic longer and sorting by it problem is I'm not sure how to compare single character I tried doing it with strcmp like

struct example
{
 char code;
}
if (strcmp(i->code, j->code) < 0)
    return 1;

warning: passing argument 1 of âstrcmpâ makes pointer from integer without a cast

warning: passing argument 2 of âstrcmpâ makes pointer from integer without a cast

I know that strcmp is for strings, should I just malloc and make the char code into a string instead, or is there another way to compare single characters?

if(i->code < j->code) /* if you're only comparing one character, you can just compare the character */ — forsvarir
– forsvarir, Commented May 8, 2011 at 22:19
Do you want case to be significant? You might want to use tolower() or one of the related functions before comparing values. — John Carter
– John Carter, Commented May 8, 2011 at 22:24

James McNellis · Accepted Answer · 2011-05-08 22:20:07Z

3

char is an integer type.

You compare char objects using the relational and equality operators (<, ==, etc.).

answered May 8, 2011 at 22:20

James McNellis

357k76 gold badges934 silver badges983 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

orlp · Accepted Answer · 2011-05-08 22:20:41Z

3

strcmp() takes a null-terminated string, so in C a char *. You are passing it a single character, a char. This char gets automatically promoted to an int in the expression (this always happens with char's in expressions in C) and then this int is attempted to change to a char*. Thank god this fails.

Use this instead:

if (i->code < j->code)

answered May 8, 2011 at 22:20

orlp

119k39 gold badges226 silver badges324 bronze badges

Comments

user142162 · Accepted Answer · 2011-05-08 22:20:14Z

2

Since you're comparing chars and not null terminated strings, do the following:

if (i->code < j->code)

answered May 8, 2011 at 22:20

user142162

Comments

Daniel Lubarov · Accepted Answer · 2011-05-08 22:20:27Z

0

Try

if (i->code < j->code)
    ...

answered May 8, 2011 at 22:20

Daniel Lubarov

7,9441 gold badge39 silver badges57 bronze badges

Collectives™ on Stack Overflow

Strcmp pointer from integer without cast

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related