powershell function: why more values are returned?

Question

Good Morning everybody, i'm writing my firts ps script: a function with 3 input string and a returned output string but something sound strange for me: this is my code:

function MyLogger($MyString, $MyFileName, $MyFilePath)
{

    $FullLogFile = ($MyFilePath +"\"+ $MyFileName)
    $DateForLog =  Get-Date -Format "yyyy-MM-dd HH:mm:ss" 
    $LogRow = ($DateForLog + " " + $MyString)
    return $LogRow
}

$LogFile = "logname.txt"

$dir = "C:\psscript\workingwithfiles"

$mystr = "stringgggg"

$ret = MyLogger($mystr, $LogFile, $dir)

Write-Host "***************print function res**************"

Write-Host $ret

Write-Host "***************end print function res**************"

why function output (return $LogRow) is this:

2020-01-28 13:11:03 stringgggg logname.txt C:\psscript\workingwithfiles

and not only this?

2020-01-28 13:11:03 stringgggg

Full output:

***************print function res**************

2020-01-28 13:11:03 stringgggg logname.txt C:\psscript\workingwithfiles

***************end print function res**************

Thank's everybody

Arguments passed to PowerShell commands should be separated by spaces, not commas. Change MyLogger($mystr, $LogFile, $dir) to MyLogger $mystr $LogFile $dir — Mathias R. Jessen
– Mathias R. Jessen, Commented Jan 28, 2020 at 12:40
Mathias R. Jessen - Thank you so much, didn't know that, it's my first script ever and i have to end it this evening so i just copied from the internet, i don't have time to study it... Thank you so much — andreapavia
– andreapavia, Commented Jan 28, 2020 at 12:56

f6a4 · Accepted Answer · 2020-01-28 12:50:54Z

1

Better use PowerShell syntax:

function MyLogger
{
    param(  [string]$MyString, 
            [string]$MyFileName, 
            [string]$MyFilePath)


    $FullLogFile = ($MyFilePath +"\"+ $MyFileName)
    $DateForLog =  Get-Date -Format "yyyy-MM-dd HH:mm:ss" 
    $LogRow = ($DateForLog + " " + $MyString)
    return $LogRow
}

$LogFile = "logname.txt"

$dir = "C:\psscript\workingwithfiles"

$mystr = "stringgggg"

$ret = MyLogger -MyString $mystr -MyFileName $LogFile -MyFilePath $dir

Write-Host "***************print function res**************"

Write-Host $ret

Write-Host "***************end print function res**************"

answered Jan 28, 2020 at 12:50

f6a4

1,8021 gold badge11 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

powershell function: why more values are returned?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related