Instead of getting array elements as output ,I'm getting array address(Output:[I@59494225) in scala----In the below code I expect output as (2,1)

Question

Here the requirement is to compare both the array elements a(i) and b(i). And update the

If a[i]>b[i] , then a is awarded 1 point
If b[i]>a[i] , then b is awarded 1 point

object MyWizard extends App {
    def compareTriplets(a:Array[Int],b:Array[Int]):Array[Int]= {
        var aCount=0
        var bCount=0
        for(i<-0 to a.length-1){
            for(j<-0 to b.length-1){
                if(i==j) {
                    if(a(i)>b(i)){
                        aCount=aCount+1
                    }else if(a(i)<b(i)){
                        bCount=bCount+1
                    }
                }
            }
        }
        val c:Array[Int]=Array(aCount,bCount)
        c
    }
    println(compareTriplets(Array(1,32,3),Array(453,2,1)))
}

That is the way Arrays are printed. You can use array.mkString("[", ", ", "]") to get a nice string representation of your data. Or do not use Arrays*+ but rather a **List which is a more high level and idiomatic data structure in Scala. Also, I would recommend you to do not use mutability and loops, but higher-order functions or recursion. Also, if the result always has two elements do not return a collection. but a tuple. Also, it seems you are not that versed in Scala, I would recommend you to follow some tutorials. — Luis Miguel Mejía Suárez
– Luis Miguel Mejía Suárez, Commented Apr 1, 2020 at 15:22

Luis Miguel Mejía Suárez · Accepted Answer · 2020-04-01 15:36:10Z

2

Here is a more efficient, idiomatic, generic and simpler implementation of your algorithm.

// This works for any type as long as we know how to compare instances of it.
def compareTriplets[T : Ordering](as: List[T], bs: List[T]): (Int, Int) = {
  import Ordering.Implicits._ // Provides the comparison operators.

  (as lazyZip bs).foldLeft((0, 0)) {
    case ((aCount, bCount), (a, b)) =>
      if (a > b) (aCount + 1, bCount)
      else if (a < b) (aCount, bCount + 1)
      else (aCount, bCount)
  }
}

edited Apr 1, 2020 at 15:36

answered Apr 1, 2020 at 15:29

Luis Miguel Mejía Suárez

23k4 gold badges31 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Krishna Kumar Over a year ago

Thank you for helping. But lazyZip is throwing compilation error even after importing import Ordering Implicits.

Luis Miguel Mejía Suárez Over a year ago

@KrishnaKumar ah sorry, laxyZip was added on 2.13 if you are in an older version, just use zip.

B.brown · Accepted Answer · 2020-04-01 15:07:24Z

-1

use a toString() method because it is being interpreted as its data address, not a string format of the data. Here is a simple geeksForGeeks example: https://www.geeksforgeeks.org/scala-map-tostring-method-with-example/

answered Apr 1, 2020 at 15:07

B.brown

215 bronze badges

1 Comment

Luis Miguel Mejía Suárez Over a year ago

pritnln always calls toString the problem is that the toString of an Array prints its address instead of its values, because of Java geniuses.

Collectives™ on Stack Overflow

Instead of getting array elements as output ,I'm getting array address(Output:[I@59494225) in scala----In the below code I expect output as (2,1)

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related