In Django, how does one override an object's delete() function?

Question

I am trying to create an application in which users are locked out from logging in due to too many failed login attempts.

To this end, if there are 5 failed logins within 5 minutes, a Lockout object is created, and the user is deactivated (is_active=False).

However, when this Lockout object is deleted, the user should be immediately made active again (is_active=True).

To do this, I must override the delete() function for the Lockout model so as to activate the user upon deletion. This code, which I think follows documentation, isn't working:

def delete(self):
        self.user.is_active = True
        self.user.save()
        super(Lockout, self).delete()

I was wondering if this was the proper way to do this?

Thanks a lot.

Ignacio Vazquez-Abrams · Accepted Answer · 2011-06-13 03:02:27Z

3

That's the correct way to do it. The problem you're having is that you're trying to delete via a QuerySet, which does not invoke the model methods. You will need to .filter(), then iterate through it calling .delete() on each model.

But it would probably be easier to create a new auth backend that checked for a lockout instead of going through these acrobatics.

answered Jun 13, 2011 at 3:02

Ignacio Vazquez-Abrams

804k160 gold badges1.4k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

dangerChihuahua007 Over a year ago

Thank you! That makes sense; deleting through the admin interface does not invoke my custom delete() function in models.py.

Collectives™ on Stack Overflow

In Django, how does one override an object's delete() function?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related